Skip to content

Conversation

@JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Jan 21, 2026

Fixes #1729

Description

Just a small bugfix, to make sure convert_pointwaterhead_freshwaterhead works for unstructured grids. This PR adds the following to convert_pointwaterhead_freshwaterhead:

  • Fix bug where edge case was not caught for ugrids
  • Add test to test edge case is caught
  • Add test cases for ugrids
  • Add type annotation

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example
  • If feature added: Added feature to API documentation
  • If pixi.lock was changed: Ran pixi run generate-sbom and committed changes

@sonarqubecloud
Copy link

@JoerivanEngelen JoerivanEngelen merged commit eb64237 into master Jan 26, 2026
8 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1729_pwhead_fwhead_ugrid branch January 26, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] - convert_pwhead_fwhead doesn't work for unstructured grids

3 participants