feat: add aws-account-id input for simplified AWS OIDC auth #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploying to AWS via the Portal's CloudFormation setup, users can now
simply provide their AWS account ID instead of constructing the full role ARN:
with:
provider: aws
aws-account-id: "123456789012"
This automatically sets AWS_ROLE_ARN to the Portal's default role name
(defang-cd-CIRole). Users who configured AWS manually with a different
role name can still use AWS_ROLE_ARN directly in the env section.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
raphaeltm
requested review from
Copilot and
lionello
and removed request for
a team
Updated Defang GitHub Action version from 1.3.0 to 1.3.1 in deployment steps.
There was a problem hiding this comment.
Pull request overview
This pull request adds a simplified way for users to authenticate with AWS via OIDC by providing just their AWS account ID instead of constructing the full IAM role ARN. When users provide the aws-account-id input, the action automatically constructs the AWS_ROLE_ARN environment variable using the Portal's default role name (defang-cd-CIRole). Users who have manually configured AWS with custom role names can still use the AWS_ROLE_ARN environment variable directly.
Changes:
- Added
aws-account-idinput parameter to simplify AWS OIDC authentication - Added logic to automatically construct
AWS_ROLE_ARNfrom the account ID - Updated documentation with AWS deployment examples and instructions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| action.yaml | Added new aws-account-id input parameter and shell script logic to construct AWS_ROLE_ARN environment variable |
| README.md | Added comprehensive AWS deployment documentation section with examples, updated version references to v1.3.0, and enhanced full example to include AWS deployment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ang-github-action into feat/aws-account-id-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying to AWS via the Portal's CloudFormation setup, users can now simply provide their AWS account ID instead of constructing the full role ARN:
This automatically sets AWS_ROLE_ARN to the Portal's default role name (defang-cd-CIRole). Users who configured AWS manually with a different role name can still use AWS_ROLE_ARN directly in the env section.