Skip to content

Fix/code quality checks#142

Merged
DeepKnowledge1 merged 10 commits intomainfrom
fix/code-quality-checks
Mar 21, 2026
Merged

Fix/code quality checks#142
DeepKnowledge1 merged 10 commits intomainfrom
fix/code-quality-checks

Conversation

@DeepKnowledge1
Copy link
Copy Markdown
Owner

🔗 Related Issue

📝 Description

  • Added comprehensive code quality enforcement infrastructure with pre-commit hooks and GitHub Actions CI
  • Configured Black (formatting), isort (import sorting), flake8 (linting), and pytest to run on every commit
  • Fixed all critical flake8 violations across the codebase (bare exceptions, unused f-strings, duplicate imports)
  • Created CONTRIBUTING.md with detailed development guidelines, setup instructions, and code quality standards
  • Established lenient but consistent flake8 rules that allow common Python patterns while blocking actual bugs
  • Added CI workflow with mandatory code-quality gate that blocks merges when quality checks fail

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation update
  • 🏗️ Infrastructure / CI/CD update

🧪 Hardware & Matrix Testing

I have successfully built and tested this code using uv on:

  • anomavision[cpu] (Standard/Edge)
  • anomavision[cu121] (CUDA 12.1)
  • anomavision[cu124] (CUDA 12.4)
  • anomavision[cu118] (CUDA 11.8)

Host OS used for testing:

  • Linux / Ubuntu
  • Windows (Native or WSL2)
  • macOS

✅ Developer Checklist

  • My code follows the core style guidelines of this project (Ruff/Black formatting).
  • I have run uv run pytest and all unit tests pass locally.
  • Lockfile Guard: If I added or modified a dependency in pyproject.toml, I have run uv lock --python 3.10 and committed the updated uv.lock file.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation accordingly (if applicable).

📸 Screenshots / Visual Proof (Optional)

Pre-commit hooks passing:

black....................................................................Passed
isort....................................................................Passed
flake8...................................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
Run pytest..............................................................Passed

Files added/modified:

  • .pre-commit-config.yaml - Pre-commit hook configuration
  • .flake8 - Flake8 linting rules
  • .github/workflows/ci.yml - Updated with code-quality job
  • CONTRIBUTING.md - Developer guidelines (new)
  • pyproject.toml - Added dev dependencies and tool configs
  • Multiple files - Fixed critical flake8 violations (F811 redefinitions, E722 bare excepts)

- Add pre-commit hooks (black, isort, flake8, pytest)
- Add .flake8 config for consistent linting
- Add CI workflow with code-quality gate
- Add CONTRIBUTING.md with dev guidelines
- Fix critical flake8 violations throughout codebase
- Add pre-commit hooks (black, isort, flake8, pytest)
- Add .flake8 config for consistent linting
- Add CI workflow with code-quality gate
- Add CONTRIBUTING.md with dev guidelines
- Fix critical flake8 violations throughout codebase
- Add pre-commit hooks (black, isort, flake8, pytest)
- Add .flake8 config for consistent linting
- Add CI workflow with code-quality gate
- Add CONTRIBUTING.md with dev guidelines
- Fix critical flake8 violations throughout codebase
@DeepKnowledge1 DeepKnowledge1 merged commit 95a6f0f into main Mar 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant