-
Notifications
You must be signed in to change notification settings - Fork 9
Add meta theorems about disjunctions and conjunctions #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fblanqui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Melanie! That's nice! Just a few things to change.
|
Let me know when you implemented those changes. |
The changes you asked for were all implemented in my last commit! |
MetaTheorems.lp
Outdated
| // lemmas on ∈ₙ | ||
|
|
||
| opaque symbol indexes_shift (l: 𝕃 nat) (n : τ nat): | ||
| π (istrue ((n +1) ∈ₙ (map (+1) l)) ⇒ istrue (n ∈ₙ l))≔ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some istrue's here and later as well. Could you please try to get rid of all of them, if possible?
CHANGES.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - MetaTheorems: theorems for structural operations on the level of clauses and literals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about splitting this file in 2: Disj and Conj?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea!
|
In the new commit, I removed all instances of "istrue" in my theorems, and I tried to remve all superfluous parentheses from the theorems. As you @fblanqui suggested, I split MetaTheorems into two file and as a result moved shared lemmas to list.lp. |
|
Thank you Melanie! @NotBad4U @ciaran-matthew-dunne @bodeveix @AntineaOgg |
Add: