fix: add reference_image to FILE_FIELDS for proper file handling#44
Merged
AdirAmsalem merged 1 commit intomainfrom Apr 5, 2026
Merged
fix: add reference_image to FILE_FIELDS for proper file handling#44AdirAmsalem merged 1 commit intomainfrom
AdirAmsalem merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
reference_imagewas missing fromFILE_FIELDSin both the sync and queue clients. This causedreference_imageto bypass the file-field handling path, meaning passing a file path or file-like object asreference_imagewould fail at validation — only raw bytes worked by accident.Flagged by Cursor Bugbot on #43.
Note
Low Risk
Low risk: a small input-handling change that only affects how
reference_imageis routed through validation/file processing in the sync and queue clients.Overview
Fixes
reference_imagehandling in both syncprocess()and async queue submissions by adding it to theFILE_FIELDSset.This ensures
reference_imagegoes through the same file-input path (placeholder-bytes validation + final override) asdata/start/end, so file paths or file-like objects are accepted consistently.Reviewed by Cursor Bugbot for commit 8b1bf16. Bugbot is set up for automated code reviews on this repo. Configure here.