Repository navigation
fix(unixfs): reuse verified chunk metadata within file reads - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadFileandReadFileRangefetched the same chunk-metadata CAS block in bothStatand range processing. Retain the metadata bytes within eachStatso file reads fetch that metadata once, then revalidate its CID and authenticated count locally before reuse. Selected-root proof verification and content-block verification remain unchanged.Add request-count regressions for whole-file, single-byte, cross-chunk, empty-range, and past-end reads, plus checks that reused metadata rejects modified bytes, a mismatched count, and an empty body. All five request-count cases failed with two fetches before the fix and pass with one afterward.
Validation:
GOWORK=off go test -p=6 -parallel=6 -timeout=10m ./...passed.GOWORK=off go vet -p=6 ./...passed.go build -p=6 -buildvcs=false ./...passed.