Skip to content

Fix test asset name#10

Merged
Kuniwak merged 1 commit into
DeNA:masterfrom
nowsprinting:fix/test_asset_name
Nov 7, 2023
Merged

Fix test asset name#10
Kuniwak merged 1 commit into
DeNA:masterfrom
nowsprinting:fix/test_asset_name

Conversation

@nowsprinting
Copy link
Copy Markdown
Contributor

Changes

  • Test asset name (not displayed in inspector window)

Reason

  • Forgot to change

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner April 8, 2023 22:44
@github-actions github-actions Bot added the fix label Apr 8, 2023
@nowsprinting
Copy link
Copy Markdown
Contributor Author

The label should be bug, but it set fix ???

@nowsprinting nowsprinting added bug Something isn't working and removed fix labels Apr 8, 2023
@nowsprinting
Copy link
Copy Markdown
Contributor Author

nowsprinting commented Apr 8, 2023

ok, need the forked owner's name in the setting file.
Using default configuration. (see https://github.com/TimonVS/pr-labeler-action#default-configuration )
can not read config file?

@Kesin11
Copy link
Copy Markdown

Kesin11 commented Apr 10, 2023

If you turn on debug mode and re-run it, you may find the cause.

@nowsprinting
Copy link
Copy Markdown
Contributor Author

I can not re-run, it because I'm not owner!

@nowsprinting
Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot added the fix label Apr 10, 2023
@Kesin11
Copy link
Copy Markdown

Kesin11 commented Apr 10, 2023

I just re-ran with debug option, but I couldn't get anything new about pr-labeler-action behavior. 😭
https://github.com/DeNA/Anjin/actions/runs/4647465277/jobs/8238811993

@Kesin11 Kesin11 removed the fix label Apr 10, 2023
@nowsprinting
Copy link
Copy Markdown
Contributor Author

Plz wait for merge this PR:
TimonVS/pr-labeler-action#80

@Kuniwak Kuniwak self-assigned this Nov 7, 2023
Copy link
Copy Markdown
Contributor

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me. Sorry for my tooooooo late reply.

@Kuniwak Kuniwak merged commit 371859e into DeNA:master Nov 7, 2023
@nowsprinting nowsprinting deleted the fix/test_asset_name branch November 7, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants