Skip to content

docs: fact-check fixes, say what the code does (#249) - #252

Merged
DavidGodefroid merged 1 commit into
mainfrom
docs/fact-check-249
Nov 14, 2026
Merged

DavidGodefroid merged 1 commit into
mainfrom
docs/fact-check-249

Conversation

@DavidGodefroid

Copy link
Copy Markdown
Owner

Closes #249

Every docs item of #249 re-verified against origin/main (473fbfa), lockhub origin/main and lockkit v0.20.0, then fixed in README, SECURITY.md, docs/, site/ and the agent templates.

What changes

  • Approval (F1, F2, M1-M3): every run needs lockhub's signed decision, taken by the human or by an auto rule of the profile in lox run. By default reads are approved automatically, k-anonymity, clear-value and PII-join warnings included; the docs now say so and point to auto.read = "ask" / lox run --manual. auto.unmask can be auto (full-auto).
  • Run / tickets (O1, O3): locksql_run waits at most 2 s for an auto decision, then answers pending; ticket TTLs (1 h read, 24 h write, 4 h grant); no 5-minute approval timeout; connect tickets (v2) after an idle close.
  • lox run vs lox attach (O2): lox run asks the console's questions in its cards; lox attach is for debugging. Also in initNextSteps, a doctor hint and the MCP server texts.
  • Managed example (F5): docs/configuration.md's managed file now loads (tls = "verify-full" and auto = { ddl = "deny" } on the profile). New internal/config/docs_examples_test.go parses every managed example of that page with ParseManaged; it failed on main with the managed profile is beyond the managed bounds.
  • Grants (F3, M5): need LEA_AGENT_TOKEN (lea agents only); locksql grant through the host launcher is documented as not reaching a console yet (launcher: locksql grant never reaches a console (no socket mount, --instance not parsed) #250).
  • Install / launcher (F6, F7, O8, O9, M23-M28): cosign prerequisite, LOCKSQL_SKIP_COSIGN only read without cosign, digest pinning, Homebrew path (brew upgrade), root-owned only in a root-owned dir, several locks routed by profile, host.docker.internal from lox run's egress gateway, lox add locksql --name NAME --credentials vault … (also fixed in docker.md).
  • Other: writes analysed by sqlast (F4), --allow-unmask not passed by lox run (F8), lox up deprecated in lockhub v0.9.0 (F9), lockhub compatibility (O4), hash-chained audit (O6), v0.x label (O7), console cells (O10), locksql_grant in 1.0 list (O11), mask modes (O12), audit error text (M6), credentials and Vault token (M7, M13, M20, M21), cut_cells count (M8), level 2 (M9), tier read (M10), stats export fields (M11), <masked bytes:N> (M12), allowed_uids (M14, M15), config copy (M16), launcher console message (M17), production :unmask (M18), reconnect (M19), MySQL timeout (M22), profile keys (M29, M30), agent-neutral wiring (M31, M32), MariaDB 10.11+ (U1), tag signing (U2), lea on by default (U3).
  • Not changed: U4 (brew trust is documented by the tap's README), U5 (external links the egress proxy refuses; not checked).

Code gaps filed apart (not fixed here)

Tests

go test ./internal/config ./internal/agentinit ./internal/sqlrefusal ./internal/client pass (golden wired_golden.json regenerated). In the agent container, cmd/locksql and internal/mcpserver socket tests fail identically on origin/main (environment); CI is the reference.

🤖 Generated with Claude Code

Fix the FALSE, OUTDATED, MISLEADING and UNVERIFIABLE items of #249 in
README, SECURITY, docs/, site/ and the agent templates: lox run's default
auto rule approves reads (k-anonymity warnings included), locksql_run
answers pending after at most 2 s, lox run asks the console's questions,
the audit log is hash-chained, the launcher's grant gap, install
prerequisites (cosign, Homebrew), credential modes, agent-neutral wiring.

The managed-file example of configuration.md now loads; a test parses
every managed example of that page. The init next steps, a doctor hint
and the MCP server texts drop lox attach and "the human decides" for
every ticket.

Code gaps filed apart: #250 (grant via launcher), #251 and lockhub#224
(warned reads auto-approved).

Closes #249

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DavidGodefroid
DavidGodefroid merged commit 8891a34 into main Nov 14, 2026
10 checks passed
@DavidGodefroid
DavidGodefroid deleted the docs/fact-check-249 branch November 14, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs fact-check: wrong or misleading claims

1 participant