Repository navigation
docs: fact-check fixes, say what the code does (#249) - #252
Merged
Merged
Conversation
Fix the FALSE, OUTDATED, MISLEADING and UNVERIFIABLE items of #249 in README, SECURITY, docs/, site/ and the agent templates: lox run's default auto rule approves reads (k-anonymity warnings included), locksql_run answers pending after at most 2 s, lox run asks the console's questions, the audit log is hash-chained, the launcher's grant gap, install prerequisites (cosign, Homebrew), credential modes, agent-neutral wiring. The managed-file example of configuration.md now loads; a test parses every managed example of that page. The init next steps, a doctor hint and the MCP server texts drop lox attach and "the human decides" for every ticket. Code gaps filed apart: #250 (grant via launcher), #251 and lockhub#224 (warned reads auto-approved). Closes #249 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249
Every docs item of #249 re-verified against
origin/main(473fbfa), lockhuborigin/mainand lockkit v0.20.0, then fixed in README, SECURITY.md,docs/,site/and the agent templates.What changes
lox run. By default reads are approved automatically, k-anonymity, clear-value and PII-join warnings included; the docs now say so and point toauto.read = "ask"/lox run --manual.auto.unmaskcan beauto(full-auto).locksql_runwaits at most 2 s for an auto decision, then answerspending; ticket TTLs (1 h read, 24 h write, 4 h grant); no 5-minute approval timeout; connect tickets (v2) after an idle close.lox runasks the console's questions in its cards;lox attachis for debugging. Also ininitNextSteps, a doctor hint and the MCP server texts.docs/configuration.md's managed file now loads (tls = "verify-full"andauto = { ddl = "deny" }on the profile). Newinternal/config/docs_examples_test.goparses every managed example of that page withParseManaged; it failed on main withthe managed profile is beyond the managed bounds.LEA_AGENT_TOKEN(lea agents only);locksql grantthrough the host launcher is documented as not reaching a console yet (launcher: locksql grant never reaches a console (no socket mount, --instance not parsed) #250).LOCKSQL_SKIP_COSIGNonly read without cosign, digest pinning, Homebrew path (brew upgrade), root-owned only in a root-owned dir, several locks routed by profile,host.docker.internalfrom lox run's egress gateway,lox add locksql --name NAME --credentials vault …(also fixed in docker.md).sqlast(F4),--allow-unmasknot passed by lox run (F8),lox updeprecated in lockhub v0.9.0 (F9), lockhub compatibility (O4), hash-chained audit (O6),v0.xlabel (O7), console cells (O10),locksql_grantin 1.0 list (O11), mask modes (O12), audit error text (M6), credentials and Vault token (M7, M13, M20, M21),cut_cellscount (M8), level 2 (M9), tierread(M10), stats export fields (M11),<masked bytes:N>(M12),allowed_uids(M14, M15), config copy (M16), launcher console message (M17), production:unmask(M18), reconnect (M19), MySQL timeout (M22), profile keys (M29, M30), agent-neutral wiring (M31, M32), MariaDB 10.11+ (U1), tag signing (U2), lea on by default (U3).brew trustis documented by the tap's README), U5 (external links the egress proxy refuses; not checked).Code gaps filed apart (not fixed here)
locksql grantnever reaches a console through the host launcher.NeverAuto) and decider side.Tests
go test ./internal/config ./internal/agentinit ./internal/sqlrefusal ./internal/clientpass (goldenwired_golden.jsonregenerated). In the agent container,cmd/locksqlandinternal/mcpserversocket tests fail identically onorigin/main(environment); CI is the reference.🤖 Generated with Claude Code