Skip to content

Bump lockkit to v0.20.0: refuse unconfined agents by default (lockkit#133) #71

Closed

Description

@DavidGodefroid

Follow-up of DavidGodefroid/lockkit#133 (confined agent by default), shipped in lockkit v0.20.0 (DavidGodefroid/lockkit#205).

Goal

Bump lockkit to v0.20.0 so that lockmq refuses agents that do not run confined, unless the profile sets unconfined = true (never on production).

Scope

  • Bump lockkit to v0.20.0 and ship the client and the console of the same version (an older console refuses the new hello member; an older client is refused as old_client).
  • No code change if the lock dials with client.Dial/DialInstance and serves with console.Run. Otherwise: send ipc.HelloParams.Confinement from confine.Check(confine.RealEnv()) and decide as console does.
  • Map the profile key unconfined to config.Base.Unconfined (in the policy fingerprint, via DiffBase) and to console.Profile.Unconfined; document it in the lock's config reference.
  • Tests that dial a console from the host now need a confined report (or unconfined = true on a test profile).

Acceptance criteria

  • lockkit v0.20.0 in go.mod; CI green.
  • Unit: unconfined = true is read into the profile, changes the fingerprint, and switching it on is a loosening.
  • Unit or e2e: an unconfined client is refused with CodeUnconfined; with unconfined = true on a non-production profile it is served; on a production profile the console refuses to start.
  • README/docs: the unconfined key and the confined-agent default; CHANGELOG (Breaking).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions