Repository navigation
test(pii): bench name columns for LooksPersonNameColumn (#163) - #201
Merged
Merged
Conversation
Add sampled name columns to the detection bench (namecolumns.jsonl): name/full_name/nom/naam columns with EN/FR/NL/DE person names, and products/roles/cities/tags/companies negatives, scored for precision and recall per language and held to the baseline. Read German -er plurals (mitglieder) and staedte as table hints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #163 (the lockkit half; #171 shipped
LooksPersonNameColumn).What
pii/testdata/bench/namecolumns.jsonl, written bybenchgen: 320 sampled name columns (80 per language, EN/FR/NL/DE). Positives:name/full_name/nom/naam/customer_name… columns in tables of people (customers,klanten,utilisateurs,mitglieder…) or neutral tables (orders,factures…) holding person names (gazetteer and synthetic, accented, titled, some blank or non-name values). Negatives:products.name("Laptop Pro 14"),roles.name("admin", "editor"),cities.name("Namur", "Liège"),tags.name("urgent"), categories, companies, and tables of people whose name column holds companies/logins only.TestBenchscoresLooksPersonNameColumnper language (namecolumns/<lang>/precision|recall), held tobaseline.json; RESULTS.md gets a "Name columns" table.TestBenchCorpusCoveragerequires ≥ 30 columns per label and language.-erplurals (mitglieder) andstaedte/städtewere not read as table hints. Fixed insingulars/thingTables.Results
Remaining misses: columns mostly of surname-first values ("Bauer, Stefan") or given names outside the gazetteer: not a whole-name match by design.
Tests
TestScoreColumns, extendedTestTableHint;go test ./...green locally.Not in this PR
public.customers.name) is a locksql change: locksql v0.18.1 does not callLooksPersonNameColumnyet. Tracked in locksql.docs: n/a (bench and test data only; the table-hint fix is internal to an existing heuristic, no documented behaviour changes).
🤖 Generated with Claude Code