Skip to content

test(hubclient): pin pending vs denied on Begin (#165) - #199

Merged
DavidGodefroid merged 1 commit into
mainfrom
fix/165-undecided-not-denied
Nov 14, 2026
Merged

DavidGodefroid merged 1 commit into
mainfrom
fix/165-undecided-not-denied

Conversation

@DavidGodefroid

Copy link
Copy Markdown
Owner

Refs #165.

Finding

lockkit already keeps the two outcomes apart: hubclient.Client.Begin returns ErrPending for a ticket with no decision yet and ErrDenied (with the decision) only for a denial the hub signed. The "denied: … hubclient: no decision yet" answer comes from locksql, whose run/grant ticket paths have no ErrPending case and fall through to a catch-all CodeDenied. lockmq, lockfile and locklog already map ErrPending to console.PendingResp. Fix tracked in DavidGodefroid/locksql#234.

Change

  • hubclient: TestPendingIsNotDenied pins the contract products rely on: undecided → ErrPending and not ErrDenied (no decision returned); denied → ErrDenied and not ErrPending, with the decision.

Test only, no behaviour change. docs: n/a.

🤖 Generated with Claude Code

An undecided ticket is ErrPending and never ErrDenied; a signed denial
is ErrDenied and never ErrPending. The denied answer seen in #165 comes
from locksql's mapping (DavidGodefroid/locksql#234).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DavidGodefroid
DavidGodefroid merged commit 8daf4b0 into main Nov 14, 2026
4 checks passed
@DavidGodefroid
DavidGodefroid deleted the fix/165-undecided-not-denied branch November 14, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant