Repository navigation
test(hubclient): pin pending vs denied on Begin (#165) - #199
Merged
Merged
Conversation
An undecided ticket is ErrPending and never ErrDenied; a signed denial is ErrDenied and never ErrPending. The denied answer seen in #165 comes from locksql's mapping (DavidGodefroid/locksql#234). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #165.
Finding
lockkit already keeps the two outcomes apart:
hubclient.Client.BeginreturnsErrPendingfor a ticket with no decision yet andErrDenied(with the decision) only for a denial the hub signed. The "denied: … hubclient: no decision yet" answer comes from locksql, whose run/grant ticket paths have noErrPendingcase and fall through to a catch-allCodeDenied. lockmq, lockfile and locklog already mapErrPendingtoconsole.PendingResp. Fix tracked in DavidGodefroid/locksql#234.Change
hubclient:TestPendingIsNotDeniedpins the contract products rely on: undecided →ErrPendingand notErrDenied(no decision returned); denied →ErrDeniedand notErrPending, with the decision.Test only, no behaviour change. docs: n/a.
🤖 Generated with Claude Code