Repository navigation
test(lox live): fix the exclusion test that hangs on macOS - #227
Merged
Merged
Conversation
…test On macOS a temporary directory is reached through a link (/var -> /private/var). The test took the lock for the raw path while lox live, like every command, names the workspace by its real one: it found no lock, did not refuse and served until the test binary timed out, which broke ci on main (the macOS job does not run on pull requests). The test now goes through a link on every platform, so it fails on Linux too without the canonical path, and bounds its wait. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YF8fKrK1XFPoTRMpemksuX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ciis red onmainsince #226:test (macos-latest)times out after 10 minutes inTestRunAndLiveExclude(cmd/lox). The macOS job does not run on pull requests, so #226 was green.Cause
A test bug, not a product bug. The test took the
lox runlock for the raw temporary path, whilelox live, like every command, names the workspace by its real path (family.CanonicalinlockFile). On macOS a temporary directory is behind a link (/var->/private/var), so the two paths gave two projects and two lock files:lox livefound no lock, did not refuse, and served for ever.In real use both commands go through
lockFile, so they always agree.Fix
ciis run by hand on this branch to get the macOS job.🤖 Generated with Claude Code