Repository navigation
Fix sponsor doc 'Checking access…' hang; fail loudly on failed page loads - #386
Merged
Merged
Conversation
…nd time out instead of hanging
…gning page, and test every page's module graph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
/sponsor-docs/:idimportssponsor-doc-guest-schedule.jsandsponsor-doc-event-time.js(added in 6e73ba0), but the anonymous asset allowlist did not include them. Anonymous visitors got a 302 to /login for those modules, so the ES module graph failed, the page script never ran, and the header stayed on "Checking access…". This affected every doc served by this page (sponsor, podcast, guest, webinar, workshop).Changes
guarded-fetchhelper: 20s timeout, visible "what failed + what to do" message, and a report to a new anonymous, throttledPOST /api/client-errorsthat writes a structuredclient_check_failedERROR log line (query strings stripped, fixed fields only).fetch(/work, {) andcore/html.jsmissing from its allowlist.