Revise Docupipe plan with concrete endpoint workflow#2
Revise Docupipe plan with concrete endpoint workflow#2matthewdavidian wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f0fb59bd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Retry exactly once on: | ||
| - transport/network failure | ||
| - HTTP 429 | ||
| - HTTP 5xx | ||
| - Do not retry on 4xx except 429. |
There was a problem hiding this comment.
Avoid retrying non-idempotent DocuPipe POST operations
The retry policy currently applies a blind retry to transport failures/429/5xx across the board, which will also hit POST /document and POST /v2/standardize/batch. If the first POST succeeded server-side but the response was lost (timeout/network drop), retrying can create duplicate documents/jobs and corrupt downstream queue state or billing counts. Please scope automatic retries to idempotent reads or require an idempotency key/deduplication strategy for submit/standardize writes.
Useful? React with 👍 / 👎.
Manually copied/pasted from Codex updated plan based on LLM.txt
Motivation
Description
docs/docupipe_integration_plan.mdwith explicit DocuPipe endpoints (POST /document,GET /document/{id},POST /v2/standardize/batch,GET /job/{id},GET /standardization/{id}) and auth/header conventions (X-API-Key, JSON headers).cDocuPipeClient,cDocuPipeDocumentService,cDocuPipeStandardizationService,cDocuPipeJobService, anddocupipeai.hwith minimaltDocuPipe*structs that pass through raw JSON and surface orchestration IDs/statuses.SubmitDocumentFromFile,SubmitDocumentFromUrl,Standardize,GetJob,GetStandardization), a single-retry-on-transient policy, and logging/diagnostics hooks.Testing
docs/docupipe_integration_plan.mdfor implementers to follow when adding unit and integration tests in later phases.submit -> documentId,standardize -> jobId, and job status transitions, plus integration tests with sample documents as described in the plan.Codex Task