Holdout prototype/demo#299
Draft
rohansub wants to merge 2 commits into
Draft
Conversation
Replace extraLogging-based holdout metadata with first-class split.holdout field per RFC. Only key and variation round-trip through the SDK; analysis experiment ID, covered experiment ID, and base allocation key are resolved server-side. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype/demo only
This is a draft PR for visualizing the SDK-side holdout exposure metadata changes. It is not intended to merge as-is.
What changed
split.extraLogginginto OpenFeatureflagMetadata.holdoutobject on exposure events when holdout metadata is present.Validation
yarn workspace @datadog/flagging-core test test/configuration/exposureEvent.spec.ts --runInBand --watchman=falseyarn workspace @datadog/openfeature-node-server test test/evaluateForSubject.spec.ts --runInBand --watchman=falseyarn workspace @datadog/openfeature-browser test test/evaluation.spec.ts --runInBand --watchman=falseyarn workspace @datadog/flagging-core typecheckyarn workspace @datadog/openfeature-node-server typecheckyarn workspace @datadog/openfeature-browser typecheckyarn prettier --check <touched files>