Skip to content

Fix release.sh script - #776

Merged
zhengyu123 merged 2 commits into
mainfrom
zgu/release_script
Sep 2, 2026
Merged

Fix release.sh script#776
zhengyu123 merged 2 commits into
mainfrom
zgu/release_script

Conversation

@zhengyu123

@zhengyu123 zhengyu123 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?:
Fix following script error.

In utils/release.sh line 667:
    ${SOURCE_SHA_FIELD:-} > "$WORKFLOW_OUTPUT" 2> "$WORKFLOW_ERROR"; then
    ^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Motivation:
Fix release.sh script that results CI failure.

Additional Notes:

How to test the change?:
CI no longer fail.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a security review (run the dd:platform-security-review
    skill, or file a request via the PSEC review form).
    bewaire also runs automatically on every PR.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Scan-Build Report

User:runner@runnervmgx7h7
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 all
Clang Version:Ubuntu clang version 18.1.3 (1ubuntu1)
Date:Tue Sep 1 19:11:11 2026

Bug Summary

Bug TypeQuantityDisplay?
All Bugs1
Logic error
Dereference of null pointer1

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Logic errorDereference of null pointerfaultInjection.cppcrashNow242

@zhengyu123 zhengyu123 changed the title Fix Fix release.sh script Sep 1, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #33629719672 | Commit: 46faf1d | Duration: 15m 9s (longest job)

1 of 32 test jobs failed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - - -
8-ibm - - -
8-j9 - -
8-librca - -
8-orcl - - -
11 - - -
11-j9 - -
11-librca - -
17 - -
17-graal - -
17-j9 - -
17-librca - -
21 - -
21-graal - -
21-librca - -
25 - -
25-graal - -
25-librca - -

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Failed Tests

musl-amd64/debug / 8-librca

Job: View logs

No detailed failure information available. Check the job logs.

Summary: Total: 32 | Passed: 31 | Failed: 1


Updated: 2026-09-02 12:43:09 UTC

@zhengyu123
zhengyu123 marked this pull request as ready for review September 1, 2026 18:33
@zhengyu123
zhengyu123 requested a review from a team as a code owner September 1, 2026 18:33
@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

All 40 integration tests passed

📊 Dashboard · 👷 Pipeline · 📦 e309c964

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6b48ccb0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread utils/release.sh Outdated
@datadog-prod-us1-4

This comment has been minimized.

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

For each normal release, the script sends --field source_sha=<SHA> as one argument. The GitHub CLI rejects this argument, so the script cannot start the release workflow.

Open Bits AI session

🤖 Datadog Autotest · Commit c6b48cc · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Comment thread utils/release.sh Outdated
@zhengyu123
zhengyu123 marked this pull request as draft September 1, 2026 19:03
@zhengyu123
zhengyu123 marked this pull request as ready for review September 1, 2026 19:24

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The array keeps --field and source_sha as two arguments. Retry mode supplies no source SHA argument.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit e309c96 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@jbachorik jbachorik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhengyu123
zhengyu123 merged commit 4ad9489 into main Sep 2, 2026
233 of 276 checks passed
@zhengyu123
zhengyu123 deleted the zgu/release_script branch September 2, 2026 12:47
@github-actions github-actions Bot added this to the 1.51.0 milestone Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants