Skip to content

Respect dbstrict in schema collection - #24923

Draft
sethsamuel wants to merge 2 commits into
masterfrom
seth.samuel/respect-dbstrict-in-postgres-schemas
Draft

Respect dbstrict in schema collection#24923
sethsamuel wants to merge 2 commits into
masterfrom
seth.samuel/respect-dbstrict-in-postgres-schemas

Conversation

@sethsamuel

@sethsamuel sethsamuel commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates Postges schema collection to only collect from the main database when dbstrict is true and autodiscovery is disabled.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 19, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   1 (always emitted)
Diff (2 files):
  postgres/changelog.d/24923.fixed
  postgres/datadog_checks/postgres/schemas.py

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 19, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 40 Pipeline jobs failed

PR | test / test (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-C), py3.13-10.0-C) / Postgres (py3.13-10.0-C)-py3.13-10.0-C — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Linting failed. Please update to the latest version of ddev and run 'ddev test --fmt postgres' to fix formatting issues.

PR | test / test (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-UTF8), py3.13-10.0-UTF8) / Postgres (py3.13-10.0-UTF8)-py3.13-10.0-UTF8 — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Linting failed due to formatting issues. Please run 'ddev test --fmt' to fix errors.

PR | test / test (linux, ubuntu-22.04, postgres, Postgres (py3.13-11.0-C), py3.13-11.0-C) / Postgres (py3.13-11.0-C)-py3.13-11.0-C — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Linting failed due to formatting issues. Please run 'ddev test --fmt' to fix errors.

View all 40 failed jobs.

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: seth.samuel/respect-dbstrict-in-postgres-schemas

PR | test / test (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-C), py3.13-10.0-C) / Postgres (py3.13-10.0-C)-py3.13-10.0-C
Commit: 628f3d71c6315b8d920e7595d1965117b84c8f43
Error (code / quality):
Linting failed. Please update to the latest version of ddev and run 'ddev test --fmt postgres' to fix formatting issues.
CI job: https://github.com/DataDog/integrations-core/actions/runs/32291866762/job/96194758525

PR | test / test (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-UTF8), py3.13-10.0-UTF8) / Postgres (py3.13-10.0-UTF8)-py3.13-10.0-UTF8
Commit: 628f3d71c6315b8d920e7595d1965117b84c8f43
Error (code / quality):
Linting failed due to formatting issues. Please run 'ddev test --fmt' to fix errors.
CI job: https://github.com/DataDog/integrations-core/actions/runs/32291866762/job/96194759086

PR | test / test (linux, ubuntu-22.04, postgres, Postgres (py3.13-11.0-C), py3.13-11.0-C) / Postgres (py3.13-11.0-C)-py3.13-11.0-C
Commit: 628f3d71c6315b8d920e7595d1965117b84c8f43
Error (code / quality):
Linting failed due to formatting issues. Please run 'ddev test --fmt' to fix errors.
CI job: https://github.com/DataDog/integrations-core/actions/runs/32291866762/job/96194758633

Plus 33 more failing jobs not shown here.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 628f3d7 | Docs | View more details | Give us feedback!

@sethsamuel sethsamuel added the qa/skip-qa Automatically skip this PR for the next QA label Aug 19, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant