Skip to content

Clarify Postgres spec usage of ignore_databases - #24922

Open
sethsamuel wants to merge 3 commits into
masterfrom
seth.samuel/postgres-docs-update
Open

Clarify Postgres spec usage of ignore_databases#24922
sethsamuel wants to merge 3 commits into
masterfrom
seth.samuel/postgres-docs-update

Conversation

@sethsamuel

Copy link
Copy Markdown
Contributor

What does this PR do?

Clarifies the Postgres spec.yaml with regards to the scope of the top level ignore_databases.

Motivation

#24531

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 19, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   1 (always emitted)
Diff (3 files):
  postgres/assets/configuration/spec.yaml
  postgres/changelog.d/24922.added
  postgres/datadog_checks/postgres/data/conf.yaml.example

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@sethsamuel sethsamuel added the qa/skip-qa Automatically skip this PR for the next QA label Aug 19, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests  Code Coverage

⚠️ Warnings

🚦 20 Pipeline jobs failed

PR | test / test-minimum-base-package (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-C), py3.13-10.0-C) / minimum-base-package-Postgres (py3.13-10.0-C)-py3.13-10.0-C — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

1 failed test. Error: Check still alive after cancel() + del -- pinned by: ['CheckLoggingAdapter']

PR | test / test-minimum-base-package (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-UTF8), py3.13-10.... / minimum-base-package-Postgres (py3.13-10.0-UTF8)-py3.13-10.0-UTF8 — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

1 failed test. Failed: Check still alive after cancel() + del -- pinned by: ['CheckLoggingAdapter'] at tests/test_unit.py:443

PR | test / test-minimum-base-package (linux, ubuntu-22.04, postgres, Postgres (py3.13-11.0-C), py3.13-11.0-C) / minimum-base-package-Postgres (py3.13-11.0-C)-py3.13-11.0-C — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

1 failed test. Error: Check still alive after cancel() + del -- pinned by: ['CheckLoggingAdapter'] in tests/test_unit.py:443.

View all 20 failed jobs.

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: seth.samuel/postgres-docs-update

PR | test / test-minimum-base-package (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-C), py3.13-10.0-C) / minimum-base-package-Postgres (py3.13-10.0-C)-py3.13-10.0-C
Commit: 3318a959faf31e908a2cc25c9da3a2f1402959dc
Error (code / test):
1 failed test. Error: Check still alive after cancel() + del -- pinned by: ['CheckLoggingAdapter']
CI job: https://github.com/DataDog/integrations-core/actions/runs/32291106145/job/96192458284

PR | test / test-minimum-base-package (linux, ubuntu-22.04, postgres, Postgres (py3.13-10.0-UTF8), py3.13-10.... / minimum-base-package-Postgres (py3.13-10.0-UTF8)-py3.13-10.0-UTF8
Commit: 3318a959faf31e908a2cc25c9da3a2f1402959dc
Error (code / test):
1 failed test. Failed: Check still alive after cancel() + del -- pinned by: ['CheckLoggingAdapter'] at tests/test_unit.py:443
CI job: https://github.com/DataDog/integrations-core/actions/runs/32291106145/job/96192458193

PR | test / test-minimum-base-package (linux, ubuntu-22.04, postgres, Postgres (py3.13-11.0-C), py3.13-11.0-C) / minimum-base-package-Postgres (py3.13-11.0-C)-py3.13-11.0-C
Commit: 3318a959faf31e908a2cc25c9da3a2f1402959dc
Error (code / test):
1 failed test. Error: Check still alive after cancel() + del -- pinned by: ['CheckLoggingAdapter'] in tests/test_unit.py:443.
CI job: https://github.com/DataDog/integrations-core/actions/runs/32291106145/job/96192458249

Plus 16 more failing jobs not shown here.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 94.19% (+5.59%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5b5e19c | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant