Skip to content

Add cached agent_version to DatabaseCheck - #24905

Merged
eric-weaver merged 2 commits into
masterfrom
eric.weaver/DBMON-6889
Aug 20, 2026
Merged

Add cached agent_version to DatabaseCheck#24905
eric-weaver merged 2 commits into
masterfrom
eric.weaver/DBMON-6889

Conversation

@eric-weaver

Copy link
Copy Markdown
Contributor

What does this PR do?

Add an agent_version property on DatabaseCheck that calls datadog_agent.get_version() once and caches the result, matching the existing agent_hostname pattern.

Motivation

datadog_agent.get_version() is an FFI call. DBM payloads include the Agent version in many places; caching it avoids repeating that call.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Made with Cursor

Avoid repeating the datadog_agent.get_version() FFI call when DBM payloads include the Agent version.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 18, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   1 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

@datadog-official

datadog-official Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 36 jobs - 35 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.69% (+0.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 234c7f9 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@eric-weaver
eric-weaver added this pull request to the merge queue Aug 20, 2026
Merged via the queue into master with commit b7957f7 Aug 20, 2026
944 of 985 checks passed
@eric-weaver
eric-weaver deleted the eric.weaver/DBMON-6889 branch August 20, 2026 15:10
@dd-octo-sts dd-octo-sts Bot added this to the 7.83.0 milestone Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants