Add cached agent_version to DatabaseCheck - #24905
Merged
Merged
Conversation
Avoid repeating the datadog_agent.get_version() FFI call when DBM payloads include the Agent version. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
evalya-impact-summaryevalya impact analysis |
Contributor
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 36 jobs - 35 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 234c7f9 | Docs | View more details | Give us feedback! |
sethsamuel
approved these changes
Aug 18, 2026
lucia-sb
approved these changes
Aug 20, 2026
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an
agent_versionproperty onDatabaseCheckthat callsdatadog_agent.get_version()once and caches the result, matching the existingagent_hostnamepattern.Motivation
datadog_agent.get_version()is an FFI call. DBM payloads include the Agent version in many places; caching it avoids repeating that call.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is mergedMade with Cursor