👷 Update dependency vite to v8#164
Conversation
|
There was a problem hiding this comment.
PR Review — Score: 4.3 / 5
Straightforward Renovate bump that brings the last Vite 7 integration fixture (electron-vite-esm) onto Vite 8, matching the coverage already exercised by forge-vite and electron-builder-vite on main. The change is correctly scoped to the e2e app only — no SDK plugin or public API changes are required. I would approve once the lockfile is brought in line with package.json.
Why 4.3: The dependency alignment is the right move for bundler coverage, the diff is minimal and low-risk, and the bump exercises the ESM electron-vite path that is distinct from the other Vite fixtures.
Why not 5: yarn.lock still pins Vite 7.3.5 while package.json requests 8.1.0, and this app lands on 8.1.0 while sibling Vite fixtures remain on 8.0.16.
Findings
- [Minor] Stale yarn.lock —
package.jsonrequests Vite 8.1.0 but the committed lockfile still resolvesvite@npm:7.3.5. - [Nit] Vite patch skew —
electron-vite-esmwill test 8.1.0 whileforge-viteandelectron-builder-vitestay on 8.0.16.
Sent by Cursor Automation: electron-sdk reviews
| "electron-vite": "5.0.0", | ||
| "typescript": "5.9.3", | ||
| "vite": "7.3.5" | ||
| "vite": "8.1.0" |
There was a problem hiding this comment.
yarn.lock in this app still resolves vite@npm:7.3.5, so the committed install graph does not match this pin. CI works around this today via yarn install --no-immutable in scripts/install-integration-apps.ts, but other Vite fixtures (forge-vite, electron-builder-vite) keep package.json and yarn.lock in sync.
Please run yarn install in e2e/integration/apps/electron-vite-esm/ and commit the updated lockfile. While here, consider aligning to 8.0.16 with the other Vite apps unless you intentionally want this fixture on the latest 8.1.x line.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a82d21d1d7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "electron-vite": "5.0.0", | ||
| "typescript": "5.9.3", | ||
| "vite": "7.3.5" | ||
| "vite": "8.1.0" |
There was a problem hiding this comment.
Keep Vite within electron-vite's peer range
This fixture still depends on electron-vite 5.0.0, and the checked-in lockfile for this app records electron-vite@npm:5.0.0 with peer vite: ^5.0.0 || ^6.0.0 || ^7.0.0 (e2e/integration/apps/electron-vite-esm/yarn.lock:2272-2284). In the electron-vite-esm integration build, installing vite 8.1.0 therefore creates an unsupported peer combination for the tool that runs electron-vite build; update electron-vite to a release that supports Vite 8 and regenerate the lockfile, or keep this app on Vite 7.
Useful? React with 👍 / 👎.
e1c09e5 to
436fba0
Compare
436fba0 to
1ee2127
Compare


This PR contains the following updates:
7.3.5→8.1.3Release Notes
vitejs/vite (vite)
v8.1.3Compare Source
Bug Fixes
es-module-lexerto 2.3.0 (#22838) (7103c3a)v8.1.2Compare Source
Bug Fixes
v8.1.1Compare Source
Features
Bug Fixes
import.meta.hot.invalidate()(#22797) (709eb8e)@importurls with lightningcss (#22718) (9fa7ab4)esbuild.jsxSideEffectswhen converting tooxc.jsx.pure(#22809) (33895ba)ERR_CLOSED_SERVERin scanner (#22784) (085a0ab)inputfromroot(#22769) (9722b07)Miscellaneous Chores
Code Refactoring
Object.valuescalls (#22790) (1113acf)Tests
v8.1.0Compare Source
Features
server.fs.denylist with common files (#22707) (61ba8fd)~for Rolldown (#22693) (9928722)Bug Fixes
Code Refactoring
rolldownOptionsproperty for chunkImportMap (#22692) (8e8816c)v8.0.16Compare Source
Bug Fixes
v8.0.15Compare Source
Features
Bug Fixes
Miscellaneous Chores
Code Refactoring
collectAllModulesfunction (#22562) (6978a9c)v8.0.14Compare Source
Features
Bug Fixes
Miscellaneous Chores
Code Refactoring
Tests
v8.0.13Compare Source
Features
onEnd(#22357) (47071ce)Bug Fixes
write=false(#22328) (158e8ae)name/originalFileNamein syntheticassetFileNamescall (#22439) (8e59c97)isBundledper environment (#22257) (a576326)Miscellaneous Chores
v8.0.12Compare Source
Features
Bug Fixes
rolldownOptionsinstead of deprecatedrollupOptionsin messages (#22400) (b675c7b)build.targetto worker bundle (#22404) (3c93fde)Miscellaneous Chores
v8.0.11Compare Source
Features
Bug Fixes
Documentation
Miscellaneous Chores
Code Refactoring
Tests
v8.0.10Compare Source
Features
Bug Fixes
hmrClient.logger.debugandhmrClient.logger.errorlooked different from other HMR logs (#22147) (a4d828f).css?inline(#22292) (83f0a78)Code Refactoring
v8.0.9Compare Source
Features
Bug Fixes
watchChangehook (#22188) (fc08bda)?rawimports (#22148) (3ec9cda)Documentation
Miscellaneous Chores
v8.0.8Compare Source
Features
Bug Fixes
dns.getDefaultResultOrdertemporary (#22202) (15f1c15)v8.0.7Compare Source
Bug Fixes
v8.0.6Compare Source
Features
Bug Fixes
Performance Improvements
getLocalhostAddressIfDiffersFromDNSwhen DNS order isverbatim(#22151) (56ec256)Miscellaneous Chores
v8.0.5Compare Source
Bug Fixes
server.fsafter stripping query as well (#22160) (a9a3df2)v8.0.4Compare Source
Features
Bug Fixes
hasBothRollupOptionsAndRolldownOptionsshould returnfalsefor proxy case (#22043) (99897d2)vite/modulepreload-polyfill(#22126) (17330d2)#(#22038) (3460fc5)Documentation
environment.fetchModuledocumentation (#22035) (54229e7)Miscellaneous Chores
Code Refactoring
v8.0.3Compare Source
Features
Bug Fixes
metaidentifier insideimport.metawhen a binding namedmetaexists (#22019) (cff5f0c)Miscellaneous Chores
Tests
getCssFilesForChunk(#22016) (43fbbf9)v8.0.2Compare Source
Features
Bug Fixes
Miscellaneous Chores
v8.0.1Compare Source
Features
Bug Fixes
inlineConstoptimization (#21865) (6d97142)build.target: 'es6'(#21933) (5fcce46)_createServer(#21810) (40bc729)+symbol in package subpath exports during dep optimization (#21886) (86db93d)no-corsrequest block error (#21902) (5ba688b)require(json)result should not be wrapped (#21847) (0672fd2)Miscellaneous Chores
@vitejs/devtoolsversion to 0.1+ (#21925) (12932f5)v8.0.0Compare Source
Features
vite-tsconfig-pathsplugin is detected (#21781) (ada493e)Bug Fixes
v7.3.6Compare Source
Please refer to CHANGELOG.md for details.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.