You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
➤ YN0087: Migrated your project to the latest Yarn version 🚀
➤ YN0000: · Yarn 4.17.0
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @datadog/electron-sdk@file:../../integration-sdk.tgz::locator=forge-vite%40workspace%3A.: ENOENT: no such file or directory, open '/tmp/renovate/repos/github/DataDog/electron-sdk/e2e/integration/integration-sdk.tgz'
➤ YN0000: └ Completed in 6s 410ms
➤ YN0000: · Failed with errors in 6s 434ms
➤ YN0087: Migrated your project to the latest Yarn version 🚀
➤ YN0000: · Yarn 4.17.0
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @datadog/electron-sdk@file:../../integration-sdk.tgz::locator=forge-esbuild-esm%40workspace%3A.: ENOENT: no such file or directory, open '/tmp/renovate/repos/github/DataDog/electron-sdk/e2e/integration/integration-sdk.tgz'
➤ YN0000: └ Completed in 5s 293ms
➤ YN0000: · Failed with errors in 5s 314ms
➤ YN0087: Migrated your project to the latest Yarn version 🚀
➤ YN0000: · Yarn 4.17.0
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @datadog/electron-sdk@file:../../integration-sdk.tgz::locator=forge-esbuild-cjs%40workspace%3A.: ENOENT: no such file or directory, open '/tmp/renovate/repos/github/DataDog/electron-sdk/e2e/integration/integration-sdk.tgz'
➤ YN0000: └ Completed in 5s 761ms
➤ YN0000: · Failed with errors in 5s 782ms
➤ YN0087: Migrated your project to the latest Yarn version 🚀
➤ YN0000: · Yarn 4.17.0
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @datadog/electron-sdk@file:../../integration-sdk.tgz::locator=electron-vite%40workspace%3A.: ENOENT: no such file or directory, open '/tmp/renovate/repos/github/DataDog/electron-sdk/e2e/integration/integration-sdk.tgz'
➤ YN0000: └ Completed in 5s 369ms
➤ YN0000: · Failed with errors in 5s 385ms
➤ YN0087: Migrated your project to the latest Yarn version 🚀
➤ YN0000: · Yarn 4.17.0
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @datadog/electron-sdk@file:../../integration-sdk.tgz::locator=electron-vite-esm%40workspace%3A.: ENOENT: no such file or directory, open '/tmp/renovate/repos/github/DataDog/electron-sdk/e2e/integration/integration-sdk.tgz'
➤ YN0000: └ Completed in 6s 344ms
➤ YN0000: · Failed with errors in 6s 366ms
➤ YN0087: Migrated your project to the latest Yarn version 🚀
➤ YN0000: · Yarn 4.17.0
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @datadog/electron-sdk@file:../../integration-sdk.tgz::locator=electron-builder-vite%40workspace%3A.: ENOENT: no such file or directory, open '/tmp/renovate/repos/github/DataDog/electron-sdk/e2e/integration/integration-sdk.tgz'
➤ YN0000: └ Completed in 4s 843ms
➤ YN0000: · Failed with errors in 4s 872ms
- replace deprecated moduleResolution: node with node16/bundler across all tsconfigs
- remove deprecated baseUrl from e2e/tsconfig.json
- add types: ["node"] to scripts/tsconfig.json
- fix hotReload.ts to use dynamic import() for esm-only chokidar v5
- remove DOM lib from playground main-process tsconfig
- add rootDir to forge-webpack and forge-vite tsconfigs (TS5011: required with module: node16 when outDir is set)
- remove unnecessary `as unknown` assertions in playground/src/main.ts (surfaced by removing DOM lib)
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
PR Review — Score: 4.4 / 5
This is a well-executed TypeScript 6 migration that goes well beyond a Renovate version bump: tsconfigs are migrated from deprecated moduleResolution: node to node16/bundler, the playground hot-reload path is fixed for ESM-only chokidar v5, and follow-up commits address CI failures (rootDir for forge apps, unnecessary as unknown casts). Nine of ten dd-gitlab/* jobs were green at review time (build, lint, unit, e2e, playground, format, and checks); dd-gitlab/integration was still pending. I would approve once integration completes.
Why 4.4: The migration is systematic across root, e2e, playground, and integration apps; code changes are minimal and purposeful; prior Codex concern about typescript-eslint peer compatibility is already resolved (8.62.0 supports typescript <6.1.0, lint CI passes).
Why not 5: Integration-app yarn.lock files were not updated alongside package.json (Renovate artifact failure), leaving a local-dev footgun; playground README still describes removed require-cache behavior; integration CI had not finished at review time.
Findings
[Minor] Stale integration lockfiles — Seven integration-app yarn.lock files still pin TypeScript 5.9.3 while package.json declares 6.0.3; CI compensates via --no-immutable, but a plain yarn install in those apps may resolve the old version.
[Nit] Playground README drift — playground/README.md still documents require-cache clearing that hotReload.ts no longer performs (full app.relaunch() makes it redundant).
- set rootDir to "." in forge-vite and forge-webpack tsconfigs (./src conflicted with root-level config files in include)
- update playground README to reflect removed require.cache clearing
The reason will be displayed to describe this comment to others. Learn more.
PR Review — Score: 4.8 / 5
This is a thorough TypeScript 6 migration that goes well beyond the Renovate version bump: tsconfigs move from deprecated moduleResolution: node to node16/bundler, integration-app lockfiles now match package.json, forge rootDir is corrected to include config files, and the playground hot-reload path uses dynamic import() for ESM-only chokidar v5. The follow-up commit addresses all prior review feedback (README drift, stale lockfiles, forge rootDir). Nine of ten dd-gitlab/* jobs were green at review time; only dd-gitlab/integration was still pending. I would approve once integration completes.
Why 4.8: The migration is systematic across root, e2e, playground, and all seven integration apps; code changes are minimal and purposeful; typescript-eslint@8.62.0 peer range (>=4.8.4 <6.1.0) covers TS 6 and lint CI passes; prior blocking concerns from Codex and the last automation run are resolved on head.
Why not 5:dd-gitlab/integration had not finished on the latest commit at review time, and a major TypeScript major-version bump always carries residual toolchain risk even when CI is otherwise green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
renovate
Bot
force-pushed
the
renovate/typescript-6.x
branch
from
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
bcaudan
force-pushed
the
renovate/typescript-6.x
branch
from
This PR contains the following updates:
5.9.3→6.0.3Release Notes
microsoft/TypeScript (typescript)
v6.0.3Compare Source
v6.0.2Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.