Skip to content

ci: build OTel operator images - #20239

Draft
dineshg13 wants to merge 4 commits into
mainfrom
dinesh.gurumurthy/add-otel-operator-image
Draft

ci: build OTel operator images#20239
dineshg13 wants to merge 4 commits into
mainfrom
dinesh.gurumurthy/add-otel-operator-image

Conversation

@dineshg13

@dineshg13 dineshg13 commented Sep 10, 2026

Copy link
Copy Markdown
Member

Description

Upgrade the shared libdatadogbuild one-pipeline template to 1.5.0 and enable its OpenTelemetry Operator-compatible image jobs for Python.

Testing

  • DD_TEST_PODMAN_COMPAT=1 DD_TEST_USER=0:0 scripts/run-tests --venv d7f4942 (Python 3.14 smoke test)
  • scripts/lint checks

Risks

The template upgrade can change shared CI jobs. The template remains version-pinned, and the PR pipeline will validate the generated OTel Operator image jobs. There are no runtime or public API changes.

Additional Notes

Python equivalent of DataDog/dd-trace-java#12255. No release note is needed because this is a CI-only change.

@dineshg13
dineshg13 requested review from a team as code owners September 10, 2026 17:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T17:19:35.919995Z 1fdbaa1 PR opened
🔒 Security Review Completed 2026-09-10T17:22:06.172610Z 1fdbaa1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dineshg13 dineshg13 added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 10, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

DataDog/apm-reliability/dd-trace-py | test sdist — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c7b2c7d | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.gitlab-ci.yml                                                          @DataDog/python-guild @DataDog/apm-core-python
.gitlab/one-pipeline.locked.yml                                         @DataDog/python-guild @DataDog/apm-core-python
.gitlab/scripts/build-wheel-helpers.sh                                  @DataDog/python-guild @DataDog/apm-core-python
.gitlab/testrunner.yml                                                  @DataDog/python-guild @DataDog/apm-core-python

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 1 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 10, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 228 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 228 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=134)
ddtrace.internal.ci_visibility.filters -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=132)
ddtrace.llmobs._integrations.litellm -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.llmobs._integrations.openai_agents -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.profiling.collector.stack -×-> ddtrace.trace  (product:profiling -> product:tracing, score=132)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@pr-commenter

pr-commenter Bot commented Sep 10, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-10 21:25:52

Comparing candidate commit c7b2c7d in PR branch dinesh.gurumurthy/add-otel-operator-image with baseline commit 7cd19f9 in branch main.

📊 Benchmarking dashboard

Found 1 performance improvements and 4 performance regressions! Performance is the same for 588 metrics, 10 unstable metrics, 6 known flaky benchmarks, 18 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-none_propagation_style

  • 🟩 execution_time [-70.810ns; -58.508ns] or [-8.835%; -7.300%]

scenario:httppropagationextract-tracecontext_headers

  • 🟥 execution_time [+2.588µs; +2.811µs] or [+7.006%; +7.608%]

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+77.397µs; +82.818µs] or [+27.659%; +29.596%]

scenario:otelspan-start

  • 🟥 execution_time [+2.265ms; +3.285ms] or [+7.003%; +10.157%]

scenario:samplingrules-high_match

  • 🟥 execution_time [+15.679µs; +18.241µs] or [+10.254%; +11.930%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-704.732ns; +757.259ns] or [-6.406%; +6.884%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-36.445ns; +29.416ns] or [-5.937%; +4.792%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1658.018ns; +1619.365ns] or [-9.736%; +9.509%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1213.143ns; +1256.885ns] or [-9.298%; +9.633%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-324.654ns; +322.733ns] or [-8.859%; +8.807%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-241.671ns; +262.689ns] or [-8.291%; +9.013%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-40.481ns; +113.264ns] or [-3.570%; +9.989%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-3786.371ns; +4238.906ns] or [-9.237%; +10.341%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-584.651ns; +950.001ns] or [-7.312%; +11.880%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-56.555µs; +54.554µs] or [-9.713%; +9.369%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.892µs; +2.026µs] or [+11.149%; +11.939%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+132.497µs; +139.065µs] or [+34.373%; +36.077%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+18.117µs; +21.990µs] or [+12.900%; +15.658%]

scenario:span-start

  • 🟥 execution_time [+1.420ms; +1.589ms] or [+9.741%; +10.897%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+370.671ns; +422.189ns] or [+12.807%; +14.588%]

scenario:tracer-small

  • 🟥 execution_time [+38.365µs; +40.431µs] or [+11.786%; +12.421%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-rstrip_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

@dineshg13
dineshg13 marked this pull request as draft September 10, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant