ci(testrunner): install pip-tools for Python 3.15 by wantsui · Pull Request #19977 · DataDog/dd-trace-py

wantsui · 2026-08-31T21:01:39Z

Description

This PR was done with codex.

While trying to enable CI for Python 3.15 support in #19909, I came across a bunch of tests that failed because they are missing the lock file/requirements.

Note that Codex found that we have to use pip<25.3 for now because newer versions of pip with pip-tools 7.5.2 (what dd-trace-py uses right now), it throws ImportError: cannot import name stdlib_pkgs from pip._internal.utils.compat.

Testing

Built docker/Dockerfile locally successfully.
Verified python3.15 -m piptools compile --help succeeds in the rebuilt image.

Risks

None to tracer runtime code. This changes only testrunner build tooling.

Additional Notes

This is temporary until Python 3.15 is out.

cit-pr-commenter-54b7da · 2026-08-31T21:01:47Z

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

cit-pr-commenter-54b7da · 2026-08-31T21:01:55Z

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

cit-pr-commenter-54b7da · 2026-08-31T21:02:01Z

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)

ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.mcp -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.debugging._debugger -×-> ddtrace.trace  (product:debugging -> product:tracing, score=133)
ddtrace.llmobs._integrations.llama_index -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.profiling.scheduler -×-> ddtrace.trace  (product:profiling -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:
uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

datadog-datadog-prod-us1 · 2026-08-31T21:10:30Z

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 5 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | build linux: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

Changelog | Validate changelog

View more details · View in GitHub Actions

Release note not found during changelog validation.

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: d576e8b | Docs | View more details | Give us feedback!}

pr-commenter · 2026-08-31T21:29:21Z

Benchmarks

Benchmark execution time: 2026-08-31 21:29:18

Comparing candidate commit d576e8b in PR branch codex/testrunner-piptools-py315 with baseline commit 93af8ce in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 7 performance regressions! Performance is the same for 575 metrics, 11 unstable metrics, 2 known flaky benchmarks, 16 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-tracecontext_headers

🟥 execution_time [+2.356µs; +2.567µs] or [+7.391%; +8.053%]

scenario:httppropagationinject-ids_only

🟥 execution_time [+2.626µs; +2.762µs] or [+15.927%; +16.749%]

scenario:iastaspects-title_aspect

🟥 execution_time [+83.057µs; +87.904µs] or [+31.097%; +32.912%]

scenario:iastaspectsospath-ospathbasename_aspect

🟥 execution_time [+123.342µs; +128.668µs] or [+30.086%; +31.385%]

scenario:iastaspectssplit-rsplit_aspect

🟥 execution_time [+22.669µs; +27.081µs] or [+15.953%; +19.058%]

scenario:telemetryaddmetric-1-count-metric-1-times

🟥 execution_time [+606.184ns; +647.288ns] or [+22.084%; +23.581%]

scenario:tracer-small

🟥 execution_time [+32.727µs; +35.771µs] or [+9.907%; +10.829%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

unstable execution_time [-721.545ns; +745.954ns] or [-6.598%; +6.821%]

scenario:coreapiscenario-core_dispatch_1_listener

unstable execution_time [-33.880ns; +32.567ns] or [-5.527%; +5.313%]

scenario:coreapiscenario-core_dispatch_50_listeners

unstable execution_time [-1663.306ns; +1632.655ns] or [-9.755%; +9.576%]

scenario:coreapiscenario-core_dispatch_exception_listeners

unstable execution_time [-1142.732ns; +1398.675ns] or [-8.709%; +10.660%]

scenario:coreapiscenario-core_dispatch_listeners

unstable execution_time [-324.734ns; +325.983ns] or [-8.839%; +8.873%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

unstable execution_time [-258.733ns; +254.625ns] or [-8.812%; +8.672%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

unstable execution_time [-65.528ns; +83.926ns] or [-5.563%; +7.124%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

unstable execution_time [-3777.277ns; +4120.973ns] or [-9.359%; +10.211%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

unstable execution_time [-720.346ns; +823.846ns] or [-8.897%; +10.175%]

scenario:flasksqli-appsec-enabled

unstable execution_time [-211.920µs; +71.963µs] or [-9.267%; +3.147%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

unstable execution_time [-62.638µs; +55.120µs] or [-10.042%; +8.837%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-casefold_noaspect

🟥 execution_time [+65.557µs; +70.324µs] or [+26.479%; +28.404%]

scenario:span-start

🟥 execution_time [+1.218ms; +1.382ms] or [+8.599%; +9.760%]

Known flaky benchmarks without significant changes:

scenario:errortrackingflasksqli-baseline
scenario:flasksimple-iast-get
scenario:iastaspects-casefold_aspect
scenario:iastaspects-index_aspect
scenario:iastaspects-ljust_noaspect
scenario:iastaspects-lower_aspect
scenario:iastaspects-replace_aspect
scenario:iastaspects-swapcase_aspect
scenario:iastaspects-title_noaspect
scenario:iastaspects-translate_aspect
scenario:iastaspects-translate_noaspect
scenario:iastaspects-upper_noaspect
scenario:packagespackageforrootmodulemapping-cache_off
scenario:packagespackageforrootmodulemapping-cache_on
scenario:sethttpmeta-all-enabled
scenario:telemetryaddmetric-record-100-metrics

ci(testrunner): install pip-tools for Python 3.15

d576e8b

wantsui added AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos changelog/no-changelog A changelog entry is not required for this PR. labels Aug 31, 2026

wantsui marked this pull request as ready for review August 31, 2026 21:06

wantsui requested a review from a team as a code owner August 31, 2026 21:06

wantsui requested review from christophe-papazian, emmettbutler and gnufede August 31, 2026 21:06

emmettbutler approved these changes Aug 31, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit a69a6a1 into main Sep 1, 2026
1354 of 1356 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the codex/testrunner-piptools-py315 branch September 1, 2026 02:04

igoragoli mentioned this pull request Sep 3, 2026

chore(benchmarks): update known flaky benchmarks #20050

Open

wantsui mentioned this pull request Sep 3, 2026

chore(ci): enable Python 3.15 support for dramatiq #19909

Open

5 tasks

Uh oh!

Conversation

wantsui commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Risks

Additional Notes

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codeowners resolved as

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Circular import analysis

⚠️ Existing circular imports

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency direction analysis

⚠️ Existing dependency direction violations

Uh oh!

datadog-datadog-prod-us1 Bot commented Aug 31, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

pr-commenter Bot commented Aug 31, 2026

Benchmarks

Explanation

More details about the CI and significant changes

scenario:httppropagationextract-tracecontext_headers

scenario:httppropagationinject-ids_only

scenario:iastaspects-title_aspect

scenario:iastaspectsospath-ospathbasename_aspect

scenario:iastaspectssplit-rsplit_aspect

scenario:telemetryaddmetric-1-count-metric-1-times

scenario:tracer-small

Unstable benchmarks

scenario:coreapiscenario-context_with_data_listeners

scenario:coreapiscenario-core_dispatch_1_listener

scenario:coreapiscenario-core_dispatch_50_listeners

scenario:coreapiscenario-core_dispatch_exception_listeners

scenario:coreapiscenario-core_dispatch_listeners

scenario:coreapiscenario-core_dispatch_no_args_listeners

scenario:coreapiscenario-core_dispatch_with_results_1_listener

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

scenario:coreapiscenario-core_dispatch_with_results_listeners

scenario:flasksqli-appsec-enabled

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

Known flaky benchmarks

scenario:iastaspects-casefold_noaspect

scenario:span-start

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wantsui commented Aug 31, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Aug 31, 2026 •

edited by datadog-official Bot

Loading