ci: adjust prof asan to avoid nightly (and other build refactoring) - #4241
Conversation
This comment has been minimized.
This comment has been minimized.
Benchmarks [ profiler ]Benchmark execution time: 2026-09-28 15:10:34 Comparing candidate commit 33488c7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.
|
Benchmarks [ tracer ]Benchmark execution time: 2026-09-28 15:47:59 Comparing candidate commit 33488c7 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 190 metrics, 1 unstable metrics.
|
18f3f57 to
7b6172b
Compare
- Image tags bookworm-6 -> bookworm-11 and clang versions in the CI docs. - The profiler is built from the root datadog-php crate; there is no profiling/Cargo.toml, and the root rust-toolchain.toml is the pin. - Profiler CI job table/matrix: add UBSAN, drop the stale ASAN row name. - buildPortableLibdatadogPhp uses stable Rust (compile_rust.sh sets RUSTC_BOOTSTRAP=1), not nightly.
7b6172b to
33488c7
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
realFlowControl
left a comment
There was a problem hiding this comment.
I think we can remove the "nightly" references completely, yes?
Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com>
Description
The main goal here is to avoid
+nightlytoolchains so we can drop it from our images, which will save a substantial amount of bytes to pull on every job. Cleans up other build and CI stuff while I'm at it, such as refactoring thecompile_profilerMake target and selecting features and some stale docs.I tried separating out the "independent" changes to docs but the changes are kind of tied together, since this is small enough, I think we can just review it instead of trying to untangle it (not worth the effort IMO).
Reviewer checklist