Re-work CODEOWNERS file by sarahchen6 · Pull Request #12996 · DataDog/dd-trace-java

sarahchen6 · 2026-10-22T18:11:12Z

What Does This Do

Re-work CODEOWNERS file to include apm-java (team of consistent library contributors) as a shared owner for all paths except shared core areas that have sole apm-java, apm-lang-platform-java, or apm-sdk-capabilities owners.

Motivation

The current review requirement for contributions is an approval from any developer with write access. However, given increasing contributions due to agentic development, we need a way to protect the shared core that defines shared APIs, agent lifecycle, test infrastructure, etc. while supporting fast, safe development.

To do this, we will re-enable codeowner review requirements with apm-java as reviewers / shared owners for all code paths except for the shared core. Effectively, changes outside the shared core require the reviews of either the product team or a member of apm-java, alleviating review burden. Changes in the shared core will require a review from the owning team -- apm-java, apm-lang-platform-java, or apm-sdk-capabilities owners.

Additional Notes

This PR may be better reviewed by checking the full result CODEOWNERS file, rather than the change diff.

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

chatgpt-codex-connector · 2026-10-22T18:13:15Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T18:15:47.201825Z	`75b4a29`	Draft marked ready
🔒 Security Review	✅ Completed 2026-10-22T18:18:40.539885Z	`75b4a29`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadog-datadog-prod-us1

More details

Tracked paths remain covered, and rule precedence preserves the intended shared-core ownership while adding apm-java as a shared owner for product paths.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 75b4a29}

dd-octo-sts · 2026-10-22T18:24:58Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.85 s	14.76 s	[-0.3%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent	13.63 s	13.69 s	[-1.1%; +0.2%] (no difference)
startup:petclinic:appsec:Agent	17.73 s	17.53 s	[+0.3%; +2.0%] (maybe worse)
startup:petclinic:iast:Agent	17.62 s	17.61 s	[-0.8%; +0.8%] (no difference)
startup:petclinic:profiling:Agent	17.20 s	17.21 s	[-1.3%; +1.2%] (no difference)
startup:petclinic:sca:Agent	17.61 s	17.61 s	[-0.9%; +0.8%] (no difference)
startup:petclinic:tracing:Agent	16.20 s	16.34 s	[-6.9%; +5.2%] (unstable)

Commit: c7e1d95b · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

dougqh · 2026-10-28T15:53:32Z

Two ownership changes that look unintended (checked by diffing effective owners for every file on master):

dd-trace-api/**/config/FeatureFlaggingConfig*: Resolve the Feature Flags settings like the SDK #12977 added a feature-flagging owner line for it on Oct 27, after this branch's last master merge. Since the PR is conflicting now, please carry that line over (with apm-java) when resolving, or it'll silently fall back to lang-platform only.
dd-java-agent/instrumentation-testing/: the explicit IDM line is gone, so it now falls under /dd-java-agent/ → lang-platform as sole owner, while /dd-java-agent/instrumentation/ keeps IDM. IDM are the main contributors there, so unless it's meant to be shared core, should it get @DataDog/apm-java @DataDog/apm-idm-java like instrumentation/?

sarahchen6 · 2026-10-28T17:30:18Z

@dougqh Updated with master so that the FeatureFlagging path is covered!

In terms of /dd-java-agent/instrumentation/ - based on the git log, it's been maintained by LP (and LP owns other testing infra such as dd-java-agent/testing/), so I moved it under LP ownership.

PerfectSlayer · 2026-10-30T13:29:50Z

dd-java-agent/instrumentation-testing/: the explicit IDM line is gone

Yes, that's a point I raised from the doc as comment but IDM never interact with this part (only consumes it).

sarahchen6 · 2026-10-30T14:51:13Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-30T14:51:18Z

View all feedbacks in Devflow UI.

2026-10-30 14:51:18 UTC ℹ️ Start processing command /merge

2026-10-30 14:51:21 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-10-30 14:51:49 UTC ⚠️ MergeQueue: This merge request build was cancelled

sarah.chen@datadoghq.com cancelled this merge request build

sarahchen6 · 2026-10-30T14:51:37Z

/merge -c

gh-worker-devflow-routing-ef8351 · 2026-10-30T14:51:41Z

View all feedbacks in Devflow UI.

2026-10-30 14:51:41 UTC ℹ️ Start processing command /merge -c

sarahchen6 · 2026-10-30T14:52:16Z

/merge -f --reason "Documentation change only - does not need additional MQ tests"

gh-worker-devflow-routing-ef8351 · 2026-10-30T14:52:21Z

View all feedbacks in Devflow UI.

2026-10-30 14:52:21 UTC ℹ️ Start processing command /merge -f --reason "Documentation change only - does not need additional MQ tests"

2026-10-30 14:52:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2026-10-30 14:52:37 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: Documentation change only - does not need additional MQ tests

Re-work CODEOWNERS file

75b4a29

sarahchen6 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Oct 22, 2026

sarahchen6 marked this pull request as ready for review October 22, 2026 18:12

sarahchen6 requested a review from a team as a code owner October 22, 2026 18:12

sarahchen6 requested review from amarziali and removed request for a team October 22, 2026 18:13

This comment has been minimized.

Sign in to view

datadog-datadog-prod-us1 Bot reviewed Oct 22, 2026

View reviewed changes

sarahchen6 added 3 commits October 22, 2026 13:46

Combine agent compatibility smoke tests ownership

e2488be

Merge branch 'master' into sarahchen6/codeowner-updates

6692bd9

Merge branch 'master' into sarahchen6/codeowner-updates

1e27ba7

sarahchen6 requested a review from dougqh October 27, 2026 13:10

Merge branch 'master' into sarahchen6/codeowner-updates

c7e1d95

PerfectSlayer approved these changes Oct 30, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit 9438712 into master Oct 30, 2026
621 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/codeowner-updates branch October 30, 2026 14:52

github-actions Bot added this to the 1.69.0 milestone Oct 30, 2026

Conversation

sarahchen6 commented Oct 22, 2026

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

This comment has been minimized.

datadog-datadog-prod-us1 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

dougqh commented Oct 28, 2026

Uh oh!

sarahchen6 commented Oct 28, 2026

Uh oh!

PerfectSlayer commented Oct 30, 2026

Uh oh!

sarahchen6 commented Oct 30, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarahchen6 commented Oct 30, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarahchen6 commented Oct 30, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading

dd-octo-sts Bot commented Oct 22, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 •

edited

Loading