Fix method-level scope diagnostic opt-outs in Spock - #12707
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The no-op feature visitor removes Spock’s default discovery rejection while the existing per-feature configuration path continues to apply enabled = false; no reportable regression was found.
🤖 Bits Code Review · Commit 0b6caca · @DataDog review to ask questions
48ba959
into
andrea.marziali/diagnose-suite-fixture-continuations
What Does This Do
Allows
@TrackScopeContinuationson individual Spock features by overriding the extension interface's default rejection. The existing instrumentation harness continues to apply each feature's diagnostic configuration.Adds a regression test verifying that a feature with a method-level opt-out is discovered and executes successfully.
Motivation
The original annotation Javadoc explicitly supports configuration for "a test class or method" and documents
enabled = false.Registering the Spock annotation extension broke that contract: method-level annotations caused
InvalidSpecExceptionduring discovery, preventing the entire specification from running.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]