Skip to content

Fix method-level scope diagnostic opt-outs in Spock - #12707

Merged
amarziali merged 1 commit into
andrea.marziali/diagnose-suite-fixture-continuationsfrom
ygree/fix-spock-method-level-scope-diagnostics
Oct 1, 2026
Merged

amarziali merged 1 commit into
andrea.marziali/diagnose-suite-fixture-continuationsfrom
ygree/fix-spock-method-level-scope-diagnostics

Conversation

@ygree

@ygree ygree commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Allows @TrackScopeContinuations on individual Spock features by overriding the extension interface's default rejection. The existing instrumentation harness continues to apply each feature's diagnostic configuration.

Adds a regression test verifying that a feature with a method-level opt-out is discovered and executes successfully.

Motivation

The original annotation Javadoc explicitly supports configuration for "a test class or method" and documents enabled = false.

Registering the Spock annotation extension broke that contract: method-level annotations caused InvalidSpecException during discovery, preventing the entire specification from running.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@ygree ygree self-assigned this Sep 30, 2026
@ygree ygree added type: bug fix Bug fix comp: testing Testing tag: no release notes Changes to exclude from release notes labels Sep 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 14.07 s [-1.1%; +0.5%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 13.06 s [-1.8%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent 17.02 s 16.98 s [-0.6%; +1.1%] (no difference)
startup:petclinic:iast:Agent 17.03 s 16.39 s [-0.5%; +8.3%] (no difference)
startup:petclinic:profiling:Agent 16.76 s 16.80 s [-1.4%; +1.0%] (no difference)
startup:petclinic:sca:Agent 16.96 s 16.75 s [+0.2%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 16.15 s 16.08 s [-0.4%; +1.2%] (no difference)

Commit: 0b6cacae · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@ygree
ygree marked this pull request as ready for review September 30, 2026 20:04
@ygree
ygree requested a review from a team as a code owner September 30, 2026 20:04
@ygree
ygree requested review from ValentinZakharov and removed request for a team September 30, 2026 20:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T20:06:30.181096Z 0b6caca Draft marked ready
🔒 Security Review ✅ Completed 2026-09-30T20:07:21.609067Z 0b6caca Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.09% (-9.74%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0b6caca | Docs | Give us feedback!

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The no-op feature visitor removes Spock’s default discovery rejection while the existing per-feature configuration path continues to apply enabled = false; no reportable regression was found.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 0b6caca · @DataDog review to ask questions

@amarziali
amarziali merged commit 48ba959 into andrea.marziali/diagnose-suite-fixture-continuations Oct 1, 2026
794 of 819 checks passed
@amarziali
amarziali deleted the ygree/fix-spock-method-level-scope-diagnostics branch October 1, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants