Skip to content

Remove redundant Java version settings from module build scripts - #12689

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
ygree/remove-redundant-java-version-config
Sep 30, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
ygree/remove-redundant-java-version-config

Conversation

@ygree

@ygree ygree commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Deletes 87 lines from 20 build.gradle files and adds nothing. Every removed line repeats something the shared conventions already do:

  • Java 8 defaults already set by the convention (gradle/java_no_deps.gradle sets Java 8 source/target and runs configureCompiler(it, VERSION_1_8) on every Java and Groovy compile task):
    • agent-aiguard, benchmark-integration: java { sourceCompatibility/targetCompatibility = 1.8 } blocks.
    • akka-http-10.0: Java 8 source/target on compileLagomTestJava and compileLagomTestGroovy.
    • resilience4j-2.0, resilience4j-reactor-2.0: configureCompiler(1.8) applied to every compile task.
    • karate-1.0: compileKarate141TestJava and compileLatestDepTestJava set to 1.8.
    • tomcat-5.5: compileLatestDepTestJava and compileLatest10TestJava set to 1.8.
    • tomcat-common: compileJmhJava set to 1.8.
    • agent-tooling: compileTest_java21Java set to 1.8.
    • java-lang-22.0: compileTestGroovy set to 1.8.
    • java-lang-11.0/15.0/17.0: the configureCompiler(1.8) call for compileCsiJava (the call-site-instrumentation plugin also sets it to 1.8).
  • Already done by tracerJava { addSourceSetFor(X) }, which always sets testJvmConstraints.minJavaVersion = X, compiles main_javaX at X, and compiles test Java tasks at X unless applyForTestSources = false:
    • minJavaVersion removed from profiling-controller-ddprof, profiling-controller-openjdk, exception-profiling, java-nio-1.8, vertx-web-5.0 (all 11) and java-lang-22.0 (25). It's still set even where applyForTestSources = false.
    • java-net-11.0: compileMain_java11Java set to 11.
    • java-nio-1.8: configureCompiler(11) on compileMain_java11Java and compileTestJava. The extra -Xlint compiler arguments stay.
    • karate-2.0: configureCompiler(21) on compileMain_java21Java and compileTestJava.
  • Also removes trailing blank lines in java-net-11.0, resilience4j-2.0 and vertx-web-5.0.

Motivation

The shared compiler setup now handles all of this centrally: it defaults every compile task to Java 8, and addSourceSetFor handles the higher-version source sets and their test settings. The per-module copies were left over from before that. They make module files harder to read and hide the overrides that really matter, like the unsetReleaseFlagReason cases in java-lang-22.0 and profiling-controller-openjdk. Only real deviations from the defaults should stay in module files.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

The shared compiler setup now handles all of this centrally: it defaults every compile task to Java 8, and addSourceSetFor handles the higher-version source sets and their test settings. The per-module copies were left over from before that. They make module files harder to read and hide the overrides that really matter, like the unsetReleaseFlagReason cases in java-lang-22.0 and profiling-controller-openjdk. Only real deviations from the defaults should stay in module files.
@ygree ygree added tag: no release notes Changes to exclude from release notes type: refactoring tag: ai generated Largely based on code generated by an AI or LLM labels Sep 29, 2026
@datadog-datadog-prod-us1-2

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.06 s 14.04 s [-0.8%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent 12.96 s 13.01 s [-1.1%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.10 s 16.97 s [-0.2%; +1.7%] (no difference)
startup:petclinic:iast:Agent 17.10 s 17.14 s [-1.1%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 16.72 s 16.92 s [-2.4%; +0.0%] (no difference)
startup:petclinic:sca:Agent 17.03 s 16.83 s [-0.0%; +2.4%] (no difference)
startup:petclinic:tracing:Agent 16.29 s 16.07 s [+0.5%; +2.3%] (maybe worse)

Commit: 8a087449 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@ygree
ygree marked this pull request as ready for review September 29, 2026 20:07
@ygree
ygree requested a review from a team as a code owner September 29, 2026 20:07
@ygree
ygree requested review from amarziali and removed request for a team September 29, 2026 20:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T20:10:58.035064Z 8a08744 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-29T20:12:34.144793Z 8a08744 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The removed compiler targets and minimum-JVM constraints remain supplied by shared Gradle conventions and tracerJava.addSourceSetFor; no configuration-order or task-type gap was identified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 8a08744 · @DataDog review to ask questions

@ygree

ygree commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-30 17:15:59 UTC ℹ️ Start processing command /merge


2026-09-30 17:16:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-30 18:26:00 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 2e5d74e into master Sep 30, 2026
615 of 621 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the ygree/remove-redundant-java-version-config branch September 30, 2026 18:25
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants