Remove redundant Java version settings from module build scripts - #12689
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
The shared compiler setup now handles all of this centrally: it defaults every compile task to Java 8, and addSourceSetFor handles the higher-version source sets and their test settings. The per-module copies were left over from before that. They make module files harder to read and hide the overrides that really matter, like the unsetReleaseFlagReason cases in java-lang-22.0 and profiling-controller-openjdk. Only real deviations from the defaults should stay in module files.
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The removed compiler targets and minimum-JVM constraints remain supplied by shared Gradle conventions and tracerJava.addSourceSetFor; no configuration-order or task-type gap was identified.
🤖 Bits Code Review · Commit 8a08744 · @DataDog review to ask questions
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
2e5d74e
into
master
What Does This Do
Deletes 87 lines from 20
build.gradlefiles and adds nothing. Every removed line repeats something the shared conventions already do:gradle/java_no_deps.gradlesets Java 8 source/target and runsconfigureCompiler(it, VERSION_1_8)on every Java and Groovy compile task):agent-aiguard,benchmark-integration:java { sourceCompatibility/targetCompatibility = 1.8 }blocks.akka-http-10.0: Java 8 source/target oncompileLagomTestJavaandcompileLagomTestGroovy.resilience4j-2.0,resilience4j-reactor-2.0:configureCompiler(1.8)applied to every compile task.karate-1.0:compileKarate141TestJavaandcompileLatestDepTestJavaset to 1.8.tomcat-5.5:compileLatestDepTestJavaandcompileLatest10TestJavaset to 1.8.tomcat-common:compileJmhJavaset to 1.8.agent-tooling:compileTest_java21Javaset to 1.8.java-lang-22.0:compileTestGroovyset to 1.8.java-lang-11.0/15.0/17.0: theconfigureCompiler(1.8)call forcompileCsiJava(the call-site-instrumentation plugin also sets it to 1.8).tracerJava { addSourceSetFor(X) }, which always setstestJvmConstraints.minJavaVersion = X, compilesmain_javaXat X, and compiles test Java tasks at X unlessapplyForTestSources = false:minJavaVersionremoved fromprofiling-controller-ddprof,profiling-controller-openjdk,exception-profiling,java-nio-1.8,vertx-web-5.0(all 11) andjava-lang-22.0(25). It's still set even whereapplyForTestSources = false.java-net-11.0:compileMain_java11Javaset to 11.java-nio-1.8:configureCompiler(11)oncompileMain_java11JavaandcompileTestJava. The extra-Xlintcompiler arguments stay.karate-2.0:configureCompiler(21)oncompileMain_java21JavaandcompileTestJava.java-net-11.0,resilience4j-2.0andvertx-web-5.0.Motivation
The shared compiler setup now handles all of this centrally: it defaults every compile task to Java 8, and
addSourceSetForhandles the higher-version source sets and their test settings. The per-module copies were left over from before that. They make module files harder to read and hide the overrides that really matter, like theunsetReleaseFlagReasoncases injava-lang-22.0andprofiling-controller-openjdk. Only real deviations from the defaults should stay in module files.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]