Fix Kotlin coroutine test scope crossing suspension - #12679
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
/code blockers |
|
View all feedbacks in Devflow UI.
Checking merge blockers for #12679...
No merge blockers detected. |
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
The expected merge time in
|
bb90ad3
into
master
What Does This Do
Moves delay(1) outside the manually activated child-span scopes in the lazy coroutine test.
A coroutine may resume on another worker after suspension. Keeping a thread-bound scope open across delay allowed it to be closed from a different thread, producing a flaky CLOSE_WRONG_THREAD / NEVER_CLOSED
diagnostic.
flowchart LR A[Worker A activates span scope] --> B[Increment counter] B --> C[Close scope on Worker A] C --> D[delay suspends coroutine] D --> E[Coroutine may resume on Worker B]The test still exercises coroutine suspension and parent-span inheritance without carrying a manually activated scope across a suspension point.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]