Remove manually listed instrumentation helpers by sarahchen6 · Pull Request #12649 · DataDog/dd-trace-java

sarahchen6 · 2026-09-25T19:39:39Z

What Does This Do

Remove manually listed instrumentation helpers

Motivation

Following #12549, we have automatic discovery of instrumentation helper methods and no longer need to manually list the helper list unless it includes undiscoverable methods

Additional Notes

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

dd-octo-sts · 2026-09-25T20:01:25Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.95 s	13.89 s	[-0.2%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent	12.92 s	13.09 s	[-1.9%; -0.6%] (maybe better)
startup:petclinic:appsec:Agent	17.06 s	16.99 s	[-0.5%; +1.3%] (no difference)
startup:petclinic:iast:Agent	17.04 s	17.10 s	[-1.1%; +0.4%] (no difference)
startup:petclinic:profiling:Agent	16.90 s	16.82 s	[-0.6%; +1.5%] (no difference)
startup:petclinic:sca:Agent	16.94 s	16.86 s	[-0.5%; +1.5%] (no difference)
startup:petclinic:tracing:Agent	16.26 s	16.16 s	[-0.6%; +1.8%] (no difference)

Commit: 577357c9 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

pr-commenter · 2026-09-25T21:03:13Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sarahchen6/remove-helpers
git_commit_date	1790366478	1790367491
git_commit_sha	`02d50d2`	`e2944b8`

See matching parameters

	Baseline	Candidate
ci_job_date	1790368905	1790368905
ci_job_id	2082420197	2082420197
ci_pipeline_id	140273254	140273254
cpu_model	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
jdkVersion	11.0.31	11.0.31
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dhttp.proxyHost=127.0.0.1 -Dhttp.proxyPort=15002 -Dhttps.proxyHost=127.0.0.1 -Dhttps.proxyPort=15002 -Dhttp.nonProxyHosts=localhost	*.localhost
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-s3vuah1j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-s3vuah1j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu	11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

chatgpt-codex-connector · 2026-09-25T21:15:45Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-25T21:19:46.820048Z	`e2944b8`	Draft marked ready
🔒 Security Review	✅ Completed 2026-09-25T21:24:09.936363Z	`e2944b8`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadog-datadog-prod-us1-2

More details

Automatic discovery covers the removed helper declarations, while manual declarations remain for undiscoverable or cross-module helpers. No actionable regression was identified.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit e2944b8 · @DataDog review to ask questions}

ojproductions

lgtm, but is there a reason some helpers are kept while others aren't?

sarahchen6 · 2026-09-28T20:03:10Z

is there a reason some helpers are kept while others aren't?

@ojproductions The lists that include helpers undiscoverable by the #12549 crawl mechanism (e.g. ones referenced via reflection only) will need to be kept. I'm working on a follow-up PR to cut down more lists though!

pr-commenter · 2026-09-29T20:50:04Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sarahchen6/remove-helpers
git_commit_date	1790697745	1790711789
git_commit_sha	`5c077f8`	`577357c`

See matching parameters

	Baseline	Candidate
ci_job_date	1790712988	1790712988
ci_job_id	2091601970	2091601970
ci_pipeline_id	141068849	141068849
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.31	11.0.31
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dhttp.proxyHost=127.0.0.1 -Dhttp.proxyPort=15002 -Dhttps.proxyHost=127.0.0.1 -Dhttps.proxyPort=15002 -Dhttp.nonProxyHosts=localhost	*.localhost
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-1eou577u 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-1eou577u 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu	11.0.31+11-post-1ubuntu1-22.04.2-Ubuntu

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

sarahchen6 · 2026-09-29T21:39:56Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-29T21:40:01Z

View all feedbacks in Devflow UI.

2026-09-29 21:40:00 UTC ℹ️ Start processing command /merge

2026-09-29 21:40:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-29 22:46:47 UTC ℹ️ MergeQueue: This merge request was merged

sarahchen6 added this pull request to stack #12552 September 25, 2026 19:39

sarahchen6 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Sep 25, 2026

This comment has been minimized.

Sign in to view

Base automatically changed from sarahchen6/add-helper-discovery to master September 25, 2026 20:01

Remove manually listed instrumentation helpers

e2944b8

sarahchen6 force-pushed the sarahchen6/remove-helpers branch from 7e9a136 to e2944b8 Compare September 25, 2026 20:18

sarahchen6 marked this pull request as ready for review September 25, 2026 21:15

sarahchen6 requested review from a team as code owners September 25, 2026 21:15

sarahchen6 requested review from ValentinZakharov and claponcet and removed request for a team September 25, 2026 21:15

datadog-datadog-prod-us1-2 Bot reviewed Sep 25, 2026

View reviewed changes

sarahchen6 requested a review from daniel-mohedano September 28, 2026 19:17

ojproductions approved these changes Sep 28, 2026

View reviewed changes

daniel-mohedano approved these changes Sep 29, 2026

View reviewed changes

sarahchen6 mentioned this pull request Sep 29, 2026

Remove more manually listed instrumentation helpers #12688

Open

Merge branch 'master' into sarahchen6/remove-helpers

577357c

ValentinZakharov approved these changes Sep 29, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit 311e16c into master Sep 29, 2026
606 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/remove-helpers branch September 29, 2026 22:46

github-actions Bot added this to the 1.67.0 milestone Sep 29, 2026

Navigation Menu

Remove manually listed instrumentation helpers - #12649

Remove manually listed instrumentation helpers#12649
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
sarahchen6/remove-helpers

sarahchen6 commented Sep 25, 2026

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Sep 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Uh oh!

ojproductions left a comment

Uh oh!

sarahchen6 commented Sep 28, 2026

Uh oh!

pr-commenter Bot commented Sep 29, 2026

Uh oh!

sarahchen6 commented Sep 29, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sarahchen6 commented Sep 25, 2026

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

pr-commenter Bot commented Sep 25, 2026

Kafka / producer-benchmark

Parameters

Summary

Uh oh!

chatgpt-codex-connector Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

ojproductions left a comment

Choose a reason for hiding this comment

Uh oh!

sarahchen6 commented Sep 28, 2026

Uh oh!

pr-commenter Bot commented Sep 29, 2026

Kafka / consumer-benchmark

Parameters

Summary

Uh oh!

sarahchen6 commented Sep 29, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dd-octo-sts Bot commented Sep 25, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 25, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 29, 2026 •

edited

Loading