Skip to content

Temporarily mark DSM benchmarks as optional - #12644

Merged
amarziali merged 1 commit into
masterfrom
andrea.marziali/optional-dsm-bench
Sep 25, 2026
Merged

amarziali merged 1 commit into
masterfrom
andrea.marziali/optional-dsm-bench

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Temporary make dsm kafka benchmark optional since maven central connection is failing. It will be restored when they will support fetching artifacts though our depot

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added the type: feature Enhancements and improvements label Sep 25, 2026
@amarziali
amarziali requested a review from a team as a code owner September 25, 2026 14:10
@amarziali amarziali added the tag: no release notes Changes to exclude from release notes label Sep 25, 2026
@amarziali
amarziali requested a review from a team as a code owner September 25, 2026 14:10
@amarziali amarziali added the comp: tooling Build & Tooling label Sep 25, 2026
@amarziali
amarziali requested review from AlexeyKuznetsov-DD and erikayasuda and removed request for a team September 25, 2026 14:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T14:11:32.909919Z 2574b4f PR opened
🔒 Security Review ✅ Completed 2026-09-25T14:12:20.951086Z 2574b4f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sarahchen6 sarahchen6 changed the title temporary make dsm bench as optional Temporarily mark DSM benchmarks as optional Sep 25, 2026
@PerfectSlayer PerfectSlayer added the tag: flaky test/disabled Disabled flaky tests label Sep 25, 2026

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The shared benchmark template makes both DSM Kafka jobs non-blocking while preserving their existing scheduling, change-detection, and manual-run behavior.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 2574b4f · @DataDog review to ask questions

@datadog-prod-us1-5

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.06 s 14.04 s [-0.6%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 13.05 s 13.07 s [-1.1%; +0.7%] (no difference)
startup:petclinic:appsec:Agent 17.03 s 16.89 s [-0.1%; +1.8%] (no difference)
startup:petclinic:iast:Agent 17.04 s 16.94 s [-0.1%; +1.3%] (no difference)
startup:petclinic:profiling:Agent 16.15 s 16.74 s [-7.6%; +0.5%] (no difference)
startup:petclinic:sca:Agent 16.95 s 16.96 s [-1.3%; +1.2%] (no difference)
startup:petclinic:tracing:Agent 16.15 s 16.23 s [-1.5%; +0.6%] (no difference)

Commit: 2574b4f8 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali

Copy link
Copy Markdown
Contributor Author

/merge -f "No need to go though the merge queue for this change - already validated"

@gh-worker-devflow-routing-ef8351

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-25 15:15:12 UTC ℹ️ Start processing command /merge -f "No need to go though the merge queue for this change - already validated"
If you need support, contact us on Slack #devflow!


2026-09-25 15:15:13 UTC ❌ Devflow: /merge -f "No need to go though the merge queue for this change - already validated"

Arguments errors:

  • --skip-checks: field is a boolean, but a value was provided. To set it to false, you need to omit it.

If you need support, contact us on Slack #devflow with those details!

@amarziali
amarziali merged commit 220ff6c into master Sep 25, 2026
616 of 620 checks passed
@amarziali
amarziali deleted the andrea.marziali/optional-dsm-bench branch September 25, 2026 15:15
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: flaky test/disabled Disabled flaky tests tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants