Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
bric3
marked this pull request as ready for review
September 25, 2026 15:21
bric3
requested review from
amarziali,
jandro996 and
manuel-alvarez-alvarez
and removed request for
a team
September 25, 2026 15:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Upgrade IAST's Error Prone to 2.50.0 and NullAway to 0.14.2. Compile IAST with JDK 25 and
--release 8, and update the iterator's nullable varargs annotations for the newer NullAway checks.Motivation
The older checker versions were not not upgraded because they enforced a Java 11 compiler (errorprone is a compiler "plugin"). Now that compilation happens on a later JDK (currently the one from the Gradle daemon (Java 25)), this requirement is no longer valid. The upgrade removes that compiler configuration, i.e. it is the java tracer default (targeting Java 8 bytecodes).
Note
With NullAway 0.14, a nullable varargs array needs a type-use annotation on the array dimension. For example, in
Iterators:The first annotation permits
nullelements; the second permits anullvarargs array. Unfortunately thejavax.annotation.Nullablecannot be placed on the array dimension. JSpecify's@Nullablesupports this placement, but it's not a declared dependency today. JetBrains annotations however are already acompileOnlydependency, and JetBrains annotations support these type-use positions. See NullAway's annotation placement guide.The above note suggests it might be useful to switch to standard JSpecify annotations at sone point, however this require to declare them as a dependency.
Additional Notes
--should-stop=ifError=FLOWtellsjavacto continue through flow analysis before stopping after an error. Error Prone 2.50.0 requires that setting otherwise the compilation fails withThe default --should-stop=ifError policy (INIT) is not supported by Error Prone.See Error Prone's installation guide.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue