Upgrade Gradle to 9.8.0 - #12641
Upgrade Gradle to 9.8.0#12641
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Proxy properties are consistently resolved through Gradle providers while preserving repository fallbacks, and Maven POM metadata moves onto each publication without changing its values. Targeted Gradle execution could not complete because external artifact repositories were unavailable.
🤖 Bits Code Review · Commit fe4de14 · @DataDog review to ask questions
dccbc12
into
master
What Does This Do
Motivation
Keep the build on the current Gradle release. See the Gradle 9.8.0 release notes.
Additional Notes
The POM change is needed because 9.8.0 now snapshots the POM task’s inputs before, by moving metadata onto the
publicationpreserves the output and avoids writing a finalized property.See Gradle's 9.8.0's release note on Up-to-date checks for POM generation in Maven publishing
It appears that
buildSrc/andtest-published-dependencies/are not properly configured to use our mirror/proxy, and it appears that when upgrading to Gradle 9.8.0, fetching new required dependencies hit Maven Central and as such got a 429 status to rate limit. This PR applies the same trick that was already applied onbuild-logic/, but I made them to use gradle properties access, rather that reading seting'sExtraProperties.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue