Skip to content

Fix exploration tests flakiness - #12639

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
jpbempel/fix-jsoup-timeout
Sep 25, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
jpbempel/fix-jsoup-timeout

Conversation

@jpbempel

Copy link
Copy Markdown
Member

What Does This Do

increase timeout for ConnectIT jsoup unit test

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

increase timeout for ConnectIT jsoup unit test
@jpbempel
jpbempel requested a review from a team as a code owner September 25, 2026 06:49
@jpbempel jpbempel added the type: bug fix Bug fix label Sep 25, 2026
@jpbempel
jpbempel removed the request for review from a team September 25, 2026 06:49
@jpbempel jpbempel added the tag: no release notes Changes to exclude from release notes label Sep 25, 2026
@jpbempel
jpbempel requested a review from evanchooly September 25, 2026 06:49
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Sep 25, 2026

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The patch increases the jsoup ConnectIT request timeout from 15 to 30 seconds. No repository evidence shows a concrete failure with the new limit.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit e5ca475 · @DataDog review to ask questions

@datadog-prod-us1-6

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Sep 25, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1790319674 1790320000
end_time 2026-09-25T07:02:41 2026-09-25T07:08:05
git_branch master jpbempel/fix-jsoup-timeout
git_commit_sha 4182477 e5ca475
start_time 2026-09-25T07:01:15 2026-09-25T07:06:40
See matching parameters
Baseline Candidate
ci_job_id 2079316286 2079316286
ci_pipeline_id 140039977 140039977
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1790318937 1790318937

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-31.595µs; +80.280µs] or [-10.241%; +26.022%]
unstable
[-42.241µs; +77.148µs] or [-12.231%; +22.339%]
unstable
[-56.683µs; +106.491µs] or [-15.680%; +29.457%]
unstable
[-225.907µs; +623.878µs] or [-20.389%; +56.307%]
same
scenario:basic same same unstable
[-35.332µs; +12.755µs] or [-10.234%; +3.695%]
unstable
[-56.349µs; +176.002µs] or [-5.326%; +16.635%]
unstable
[-154.811op/s; +154.811op/s] or [-6.657%; +6.657%]
scenario:loop same same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (345.354 µs) : 321, 370
.   : milestone, 345,
basic (332.039 µs) : 312, 353
.   : milestone, 332,
loop (8.09 ms) : 8027, 8152
.   : milestone, 8090,
section candidate
noprobe (362.807 µs) : 286, 439
.   : milestone, 363,
basic (324.419 µs) : 316, 332
.   : milestone, 324,
loop (8.096 ms) : 8032, 8159
.   : milestone, 8096,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 345.354 µs [321.005 µs, 369.702 µs]
basic 332.039 µs [311.542 µs, 352.537 µs]
loop 8.09 ms [8.027 ms, 8.152 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 362.807 µs [286.341 µs, 439.274 µs]
basic 324.419 µs [316.495 µs, 332.343 µs]
loop 8.096 ms [8.032 ms, 8.159 ms]

@dd-octo-sts

dd-octo-sts Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.04 s 13.95 s [-0.1%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 12.93 s 13.01 s [-1.5%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 17.62 s 17.49 s [-0.1%; +1.6%] (no difference)
startup:petclinic:iast:Agent 17.46 s 17.01 s [-2.1%; +7.3%] (no difference)
startup:petclinic:profiling:Agent 17.00 s 17.49 s [-4.0%; -1.5%] (significantly better)
startup:petclinic:sca:Agent 17.60 s 17.41 s [+0.1%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.52 s 16.73 s [-2.5%; -0.1%] (maybe better)

Commit: e5ca4754 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit ec29324 into master Sep 25, 2026
618 of 621 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/fix-jsoup-timeout branch September 25, 2026 10:23
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants