Default the compiler toolchain to the Gradle daemon - #12627
Merged
AlexeyKuznetsov-DD merged 1 commit intoSep 24, 2026
Merged
Conversation
bric3
added
tag: no release notes
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (351.897 µs) : 306, 398
. : milestone, 352,
basic (321.918 µs) : 315, 329
. : milestone, 322,
loop (8.085 ms) : 8022, 8148
. : milestone, 8085,
section candidate
noprobe (350.203 µs) : 308, 392
. : milestone, 350,
basic (324.776 µs) : 319, 331
. : milestone, 325,
loop (8.092 ms) : 8029, 8156
. : milestone, 8092,
|
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
bric3
commented
Sep 24, 2026
| ext.configureCompiler = (AbstractCompile it, int toolchainVersion, JavaVersion bytecodeVersion, String unsetReleaseFlagReason = null) -> { | ||
| configureCompiler(it, toolchainVersion, bytecodeVersion, unsetReleaseFlagReason) | ||
| } as Closure<Void> | ||
| ext.configureCompiler = this.&configureCompiler |
Contributor
Author
There was a problem hiding this comment.
note: shorthand to expose configureCompiler methods as a "callable Gradle property"
thisis the current script instance.&configureCompileris a Groovy’s method pointer operator. It creates aClosurereferring to that method, without calling it. Think roughly Java’sthis::configureCompiler.
What is interesting in this, is that the overload selection happens when the closure is actually called.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadog-prod-us1-6[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
AlexeyKuznetsov-DD
merged commit Sep 24, 2026
8f9282c
into
alexeyk/use-java-25
1242 of 1251 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Default
configureCompilerto the Gradle daemon's Java version in both Groovy and Kotlin build scripts. Remove redundant25arguments while keeping bytecode targets explicit and retaining the documented JDK exceptions.Motivation
Implement the compiler default suggestion and bootstrap suggestion, so the daemon configuration also determines the usual compiler version.
Additional Notes
Targets
alexeyk/use-java-25: merge this PR into that branch before merging #12305 intomaster.The Java 25 preview smoke test keeps an explicit JDK 25 pin, with a reason, because preview compilation requires the matching compiler version.
A targeted configuration check verified daemon defaults, release flags, and JDK exceptions across Java, Groovy, Scala, and Kotlin DSL calls. Representative Java/Groovy and preview compilation passed; the full test suite was not run for this build-script change.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue