Skip to content

Promote TableTest as default parameterized for Junit testing - #12614

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/promote-tabletest
Sep 24, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/promote-tabletest

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Promotes using @TableTest for junit testing when doing data driven parameterized tests. The recommendation is already on the groovy to java test migration but not promoted enough in the testing guidelines. Doing that, agents can keep this as new de facto.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from a team as a code owner September 23, 2026 15:20
@amarziali amarziali added type: feature Enhancements and improvements comp: testing Testing labels Sep 23, 2026
@amarziali
amarziali requested review from vandonr and removed request for a team September 23, 2026 15:20
@amarziali amarziali added the tag: no release notes Changes to exclude from release notes label Sep 23, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T15:22:26.700916Z c81b14e PR opened
🔒 Security Review ✅ Completed 2026-09-23T15:24:26.366304Z c81b14e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one minor suggestion.

Comment thread docs/how_to_test.md Outdated

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Autotest was unable to complete this review. View session

Please try again by commenting @autotest review.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.29% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c974c06 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)

Suite Status
Startup 🟡 warning

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.79 s 14.69 s [+0.0%; +1.4%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.71 s 13.77 s [-1.3%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.78 s 17.38 s [+1.4%; +3.1%] (significantly worse)
startup:petclinic:iast:Agent 17.50 s 17.65 s [-1.8%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 17.50 s 17.59 s [-1.7%; +0.8%] (no difference)
startup:petclinic:sca:Agent 17.63 s 17.55 s [-0.4%; +1.2%] (no difference)
startup:petclinic:tracing:Agent 16.59 s 16.35 s [-3.0%; +5.9%] (no difference)

Commit: c974c06b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-24 08:32:29 UTC ℹ️ Start processing command /merge


2026-09-24 08:32:34 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-24 09:29:04 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit bb85a75 into master Sep 24, 2026
605 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/promote-tabletest branch September 24, 2026 09:29
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants