Fix tests using precompiled MyResource class - #12603
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89f4c525a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 6 performance regressions! Performance is the same for 3 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (376.426 µs) : 342, 411
. : milestone, 376,
basic (331.644 µs) : 321, 342
. : milestone, 332,
loop (7.589 ms) : 7581, 7597
. : milestone, 7589,
section candidate
noprobe (359.281 µs) : 332, 386
. : milestone, 359,
basic (343.127 µs) : 337, 349
. : milestone, 343,
loop (8.115 ms) : 8051, 8179
. : milestone, 8115,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
dougqh
left a comment
There was a problem hiding this comment.
🤖 Generated with Claude Code
dougqh
left a comment
There was a problem hiding this comment.
Overall, looks reasonable to me.
I see there are some bot comments, and Claude found a small issue when I asked it to review. I'll leave those to your discretion to address.
instead of loading a precompiled and preinstrumented class, we are compiling and instrumenting with JAX-RS instrumentation on-the-fly. Add InstrumentationTestHelper.installTracerInstrumentation(), which self-attaches and applies the real JAX-RS InstrumenterModule via AgentInstaller Modify CapturedSnapshotTest.tracerInstrumentedClass and MetricProbesInstrumentationTest.localVarNotInScope
use jax-rs 2 api
f63eb41 to
7aa786f
Compare
What Does This Do
instead of loading a precompiled and preinstrumented class, we are compiling and instrumenting with JAX-RS instrumentation on-the-fly. Add InstrumentationTestHelper.installTracerInstrumentation(), which self-attaches and applies the real JAX-RS InstrumenterModule via AgentInstaller
Modify CapturedSnapshotTest.tracerInstrumentedClass and MetricProbesInstrumentationTest.localVarNotInScope
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-6226