Enable Guidewire instrumentation by default - #12594
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently flip the integration’s default enablement across runtime behavior, metadata, and tests without introducing new logic or risk-prone code paths.
Review effort: Lite
Findings: None
What changed in this PR
This PR enables the Guidewire instrumentation by default, so Guidewire WSI outbound SOAP spans inherit the parent request trace context out of the box (while still allowing users to opt out via config).
Changes:
- Flip
DD_TRACE_GUIDEWIRE_ENABLEDdefault totruein supported configuration metadata. - Remove the Guidewire instrumentation’s
defaultEnabled()override so it follows the standard integration enablement default. - Simplify the Guidewire instrumentation test by removing the explicit config override that is no longer needed.
| File | Description |
|---|---|
| metadata/supported-configurations.json | Changes the documented default of DD_TRACE_GUIDEWIRE_ENABLED to true. |
| dd-java-agent/instrumentation/guidewire-10.0/src/main/java/datadog/trace/instrumentation/guidewire/WsiAsyncResponseInstrumentation.java | Removes the disabled-by-default override so the integration is enabled by default. |
| dd-java-agent/instrumentation/guidewire-10.0/src/test/java/datadog/trace/instrumentation/guidewire/WsiAsyncResponseInstrumentationTest.java | Drops the explicit enablement annotation now that the integration defaults to enabled. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
340cb85 to
693f359
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The supported-configurations entry for DD_TRACE_GUIDEWIRE_ENABLED changes the registry version to "B", which is inconsistent with the documented _ENABLED entry shape and should remain "A".
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
f0079b8
into
master

What Does This Do
Enables the Guidewire instrumentation by default.
It was introduced disabled-by-default in #12125. This removes the defaultEnabled() override (so it follows the normal integration default) and flips
DD_TRACE_GUIDEWIRE_ENABLEDto true in the supported-configurations metadata. The test no longer needs to force-enable the integration, so its @WithConfig override is dropped.Motivation
The Guidewire WSI change propagates trace context across the raw thread Guidewire spawns for each outbound SOAP call, so those spans stay attached to their request trace instead of orphaning. Shipping it on by default means Guidewire users get complete SOAP traces out of the box, without setting
dd.trace.guidewire.enabled=truemanually.Users can still opt out with
dd.trace.guidewire.enabled=false(orDD_TRACE_GUIDEWIRE_ENABLED=false).Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]