Skip to content

Enable Guidewire instrumentation by default - #12594

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
vzakharov/guidewire-enabled-by-default
Sep 22, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
vzakharov/guidewire-enabled-by-default

Conversation

@ValentinZakharov

Copy link
Copy Markdown
Contributor

What Does This Do

Enables the Guidewire instrumentation by default.

It was introduced disabled-by-default in #12125. This removes the defaultEnabled() override (so it follows the normal integration default) and flips DD_TRACE_GUIDEWIRE_ENABLED to true in the supported-configurations metadata. The test no longer needs to force-enable the integration, so its @WithConfig override is dropped.

Motivation

The Guidewire WSI change propagates trace context across the raw thread Guidewire spawns for each outbound SOAP call, so those spans stay attached to their request trace instead of orphaning. Shipping it on by default means Guidewire users get complete SOAP traces out of the box, without setting dd.trace.guidewire.enabled=true manually.

Users can still opt out with dd.trace.guidewire.enabled=false (or DD_TRACE_GUIDEWIRE_ENABLED=false).

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@ValentinZakharov ValentinZakharov self-assigned this Sep 21, 2026
@ValentinZakharov
ValentinZakharov requested review from a team as code owners September 21, 2026 19:56
@ValentinZakharov ValentinZakharov added the type: feature Enhancements and improvements label Sep 21, 2026
@ValentinZakharov
ValentinZakharov requested review from amarziali and removed request for a team September 21, 2026 19:56
@ValentinZakharov
ValentinZakharov requested review from vandonr and a lite review from Copilot and removed request for a team, amarziali and vandonr September 21, 2026 19:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The changes consistently flip the integration’s default enablement across runtime behavior, metadata, and tests without introducing new logic or risk-prone code paths.

Review effort: Lite
Findings: None

What changed in this PR

This PR enables the Guidewire instrumentation by default, so Guidewire WSI outbound SOAP spans inherit the parent request trace context out of the box (while still allowing users to opt out via config).

Changes:

  • Flip DD_TRACE_GUIDEWIRE_ENABLED default to true in supported configuration metadata.
  • Remove the Guidewire instrumentation’s defaultEnabled() override so it follows the standard integration enablement default.
  • Simplify the Guidewire instrumentation test by removing the explicit config override that is no longer needed.
File Description
metadata/​supported-configurations.json Changes the documented default of DD_TRACE_GUIDEWIRE_ENABLED to true.
dd-java-agent/​instrumentation/​guidewire-10.0/​src/​main/​java/​datadog/​trace/​instrumentation/​guidewire/​WsiAsyncResponseInstrumentation.java Removes the disabled-by-default override so the integration is enabled by default.
dd-java-agent/​instrumentation/​guidewire-10.0/​src/​test/​java/​datadog/​trace/​instrumentation/​guidewire/​WsiAsyncResponseInstrumentationTest.java Drops the explicit enablement annotation now that the integration defaults to enabled.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The configuration metadata matches runtime activation. Users can still disable the Guidewire integration.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 340cb85 · @DataDog review to ask questions

@ValentinZakharov
ValentinZakharov force-pushed the vzakharov/guidewire-enabled-by-default branch from 340cb85 to 693f359 Compare September 21, 2026 20:13
@ValentinZakharov
ValentinZakharov requested review from ygree and a lite review from Copilot September 21, 2026 20:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The supported-configurations entry for DD_TRACE_GUIDEWIRE_ENABLED changes the registry version to "B", which is inconsistent with the documented _ENABLED entry shape and should remain "A".

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)

Comment thread metadata/supported-configurations.json
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 59.12% (-0.09%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 693f359 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.81 s 14.68 s [-0.1%; +1.9%] (no difference)
startup:insecure-bank:tracing:Agent 13.65 s 13.68 s [-1.1%; +0.7%] (no difference)
startup:petclinic:appsec:Agent 17.09 s 16.47 s [-0.7%; +8.2%] (no difference)
startup:petclinic:iast:Agent 17.02 s 17.10 s [-1.4%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.87 s 16.80 s [-0.8%; +1.6%] (no difference)
startup:petclinic:sca:Agent 17.07 s 16.72 s [+1.3%; +2.8%] (significantly worse)
startup:petclinic:tracing:Agent 16.22 s 15.81 s [-1.7%; +6.9%] (no difference)

Commit: 693f3596 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@ValentinZakharov
ValentinZakharov added this pull request to the merge queue Sep 22, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 22, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-22 06:57:06 UTC ℹ️ Start processing command /merge


2026-09-22 06:57:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-22 08:04:01 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 22, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit f0079b8 into master Sep 22, 2026
812 of 818 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the vzakharov/guidewire-enabled-by-default branch September 22, 2026 08:04
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: guidewire type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants