Conversation
bric3
added
type: bug fix
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
5a1cb32 to
68ed60e
Compare
bric3
changed the title
![datadog-datadog-prod-us1-2[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please try again by commenting @autotest review.
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (356.392 µs) : 335, 378
. : milestone, 356,
basic (346.873 µs) : 330, 364
. : milestone, 347,
loop (8.117 ms) : 8054, 8181
. : milestone, 8117,
section candidate
noprobe (359.118 µs) : 336, 382
. : milestone, 359,
basic (336.546 µs) : 329, 344
. : milestone, 337,
loop (7.59 ms) : 7581, 7598
. : milestone, 7590,
|
jpbempel
left a comment
jpbempel
left a comment
There was a problem hiding this comment.
LGTM. thanks for fixing that!
68ed60e to
4ebc1ed
Compare
bric3
changed the title
f0c9cdf to
944f291
Compare
944f291 to
b14d757
Compare
There was a problem hiding this comment.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for f5b1a23: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 935b915: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for bb6a72a: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
Claude found a couple small issues, I'll leave those to your discretion
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
🤖 Generated with Claude Code
Approving — leaving the two notes below to your discretion.
| @@ -34,6 +34,25 @@ build-exploration-tests-image: | |||
| - when: manual | |||
| allow_failure: true | |||
| before_script: | |||
There was a problem hiding this comment.
This proxy routing is only added to .common-exploration-tests's before_script, not to build-exploration-tests-image (the image-build job above), which still resolves dependencies directly against the public internet. That job's Dockerfile runs mvn verify -DskipTests=true (jsoup/jackson/jackson-databind) and ./gradlew dependencies (okhttp) with no proxy configured at all (dd-java-agent/agent-debugger/exploration-tests/Dockerfile.exploration-tests). If direct access to Maven Central / Gradle Plugin Portal is what motivated this PR (unreliable/blocked egress), image builds will keep failing or flaking exactly as before, while only the downstream test-execution job is fixed — an incomplete fix for the stated goal of "routing exploration builds through repository proxies."
🤖 Generated with Claude Code
| <mirror> | ||
| <id>env-proxy</id> | ||
| <mirrorOf>*</mirrorOf> | ||
| <url>${MAVEN_REPOSITORY_PROXY}</url> |
There was a problem hiding this comment.
The generated ~/.m2/settings.xml interpolates ${MAVEN_REPOSITORY_PROXY} into an XML document unescaped inside a heredoc. If MAVEN_REPOSITORY_PROXY is ever changed to a URL containing & (e.g. a query-string-based proxy endpoint) without being percent-encoded, the generated settings.xml becomes malformed XML and Maven fails to parse it, breaking every exploration-tests job silently until someone diagnoses the generated file. Currently benign only because the configured value has no &.
🤖 Generated with Claude Code
This branch has not been deployed
4 participants
What Does This Do
Routes Maven and Gradle builds launched by debugger exploration tests through the configured repository proxies. Each job generates Maven mirror settings and installs the existing Gradle repository init script in its user home.
Motivation
Exploration jobs build third-party projects directly and do not extend the shared Gradle build job. The repository proxy variables were therefore present but never translated into configuration understood by Maven or Gradle.
This left exploration jobs able to contact Maven Central directly and fail with HTTP 429 responses, as seen in job 2061570544.
Additional Notes
The change covers the Maven-based suites and the Gradle-based OkHttp runtime job. The manually rebuilt exploration-test image is unchanged.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue