Skip to content

Wait for Reactor Kafka test pipelines to finish #12501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 3 commits into from
Sep 17, 2026
+14 −10
Merged

Wait for Reactor Kafka test pipelines to finish #12501

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f1e243
Wait for Reactor Kafka test pipelines to finish
amarziali Sep 15, 2026
297eee1
Clarify Reactor Kafka completion ordering
amarziali Sep 15, 2026
8281aad
Wait for Reactor Kafka commits before stopping receiver
amarziali Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions ...nt/instrumentation/kafka/kafka-clients-0.11/src/test/groovy/KafkaReactorForkedTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,17 @@ class KafkaReactorForkedTest extends InstrumentationSpecification {
}
})

// create a thread safe queue to store the received message
kafkaReceiver.receive()
def commitsCompleted = new CountDownLatch(100)
def receiverSubscription = kafkaReceiver.receive()
// publish on another thread to be sure we're propagating that receive span correctly
.publishOn(Schedulers.parallel())
.flatMap {
receiverRecord -> {
receiverRecord.receiverOffset().commit()
}
.flatMap { receiverRecord ->
receiverRecord.receiverOffset().commit().then(Mono.just(receiverRecord))
}
.subscribeOn(Schedulers.parallel())
.subscribe()
.subscribe {
commitsCompleted.countDown()
}


// wait until the container has the required number of assigned partitions
Expand All @@ -152,12 +152,13 @@ class KafkaReactorForkedTest extends InstrumentationSpecification {
kafkaSender.send(Mono.just(SenderRecord.create(new ProducerRecord<>(KafkaClientTestBase.SHARED_TOPIC, greeting), null)))
}
.publishOn(Schedulers.parallel())
.subscribe()
.blockLast()
assert commitsCompleted.await(30, TimeUnit.SECONDS)
receiverSubscription.dispose()
then:
// check that the all the consume (100) and the send (100) are reported
TEST_WRITER.waitForTraces(200)
Map<String, List<DDSpan>> traces = TEST_WRITER.inject([:]) {
map, entry ->
Map<String, List<DDSpan>> traces = TEST_WRITER.inject([:]) { map, entry ->
def key = entry.get(0).getTraceId().toString()
map[key] = (map[key] ?: []) + entry
return map
Expand All @@ -174,6 +175,9 @@ class KafkaReactorForkedTest extends InstrumentationSpecification {
assert it.get(consumeIndex).getParentId() == it.get(produceIndex).getSpanId()
assert it.get(produceIndex).getParentId() == 0
}
cleanup:
receiverSubscription?.dispose()
kafkaSender?.close()
}

def producerSpan(
Expand Down