Skip to content

fix tibco bw instrumentation for 5.16 - #12449

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
vandonr/fix2
Sep 11, 2026
Merged

fix tibco bw instrumentation for 5.16#12449
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
vandonr/fix2

Conversation

@vandonr

@vandonr vandonr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

A customer reported that instrumentation failed for Tibco BusinessWorks 5.16 with the following error:

Cannot assign com.tibco.pe.core.JobData arg0 to interface com.tibco.pe.plugin.ProcessContext

turns out this was not due to a signature change, but int introduction of a new (private) method that matched the selector as well, causing the whole instrumentation to fail.

Here are the methods in 5.16:

public final void addJob(Job job, String value, boolean flag);

Job addJob(JobData data) throws Exception; // new in 5.16

protected void removeJob(Job job, boolean flag1, boolean flag2);

I fixed it by adding a constraint matching the type we expect in the advice. Did the same for removeJob because it made sense.

Motivation

APMS-20455

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@vandonr
vandonr requested a review from a team as a code owner September 10, 2026 08:59
@vandonr
vandonr requested review from ValentinZakharov and removed request for a team September 10, 2026 08:59
@dd-octo-sts

dd-octo-sts Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T09:02:34.566138Z fb30609 PR opened
🔒 Security Review Completed 2026-09-10T09:05:13.887926Z fb30609 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vandonr vandonr added type: bug fix Bug fix inst: others All other instrumentations labels Sep 10, 2026

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The new matcher selects methods whose first argument implements ProcessContext. It excludes the incompatible Tibco 5.16 JobData overload.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit fb30609 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 13.90 s [-0.2%; +1.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 13.03 s [-1.6%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 17.58 s 17.52 s [-0.6%; +1.3%] (no difference)
startup:petclinic:iast:Agent 17.47 s 17.62 s [-1.7%; -0.0%] (maybe better)
startup:petclinic:profiling:Agent 17.59 s 17.44 s [-0.3%; +2.0%] (no difference)
startup:petclinic:sca:Agent 16.98 s 17.54 s [-7.5%; +1.1%] (no difference)
startup:petclinic:tracing:Agent 16.55 s 16.64 s [-1.6%; +0.5%] (no difference)

Commit: 3eccb22e · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@ValentinZakharov

Copy link
Copy Markdown
Contributor

Assume it's tested

@vandonr

vandonr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Assume it's tested

narrator: it was not

😅 but I will before I merge, I pushed it to have a snapshot for the customer, and I'll take a look at tibco testing to test this

@vandonr

vandonr commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Ok, I was able to run the tests in tibco-testing with the old 5.14 version, donfirming no regression, and also with 5.16, with the current latest release to reproduce the failure, and with the snapshot of the change to validate that it worked fine. I'll add a constraint that the methods need to be public like Andrea suggested, and then merge this

@vandonr
vandonr added this pull request to the merge queue Sep 11, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 11, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-11 11:13:53 UTC ℹ️ Start processing command /merge


2026-09-11 11:13:58 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-11 12:44:12 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 11, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4eb5971 into master Sep 11, 2026
603 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the vandonr/fix2 branch September 11, 2026 12:44
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: others All other instrumentations type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants