Exclude unused transitive dependencies from Muzzle checks - #12396
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 771106e | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The exclusions affect only Muzzle dependency resolution. They do not change compile, test, or runtime dependencies.
🤖 Datadog Autotest · Commit 771106e · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 25219f8: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge -f --reason "No need to run on MQ, since we skip Muzzle tests on MQ" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: No need to run on MQ, since we skip Muzzle tests on MQ |
What Does This Do
Exclude unused transitive dependencies from generated Muzzle configurations:
Motivation
Muzzle resolves the complete transitive graph of every tested coordinate, including dependencies that the instrumentation does not reference.
The Log4j dependencies require parent POMs that Depot rejects with
403 Forbidden. Falling back to Maven Central then receives429 Too Many Requests. The AWS SNS inverse check for version 1.9.0 similarly reaches a dynamicjoda-time:[2.2,)dependency. Cucumber formatter dependencies also introduce dynamicio.cucumber:queryranges. Resolving either range requests rate-limited Maven metadata.These resolution errors happen before Muzzle can perform compatibility validation. Excluding the unused artifacts keeps the generated classpaths focused on dependencies needed for linkage. Instrumentation compile, test, and runtime dependencies are unchanged, as are direct checks of the Log4j instrumentation.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue