Skip to content

Validate scheduled builds with refreshed dependency locks - #12392

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
fix/dd-trace-ot-shadow-order
Sep 4, 2026
Merged

Validate scheduled builds with refreshed dependency locks#12392
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
fix/dd-trace-ot-shadow-order

Conversation

@bric3

@bric3 bric3 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Refreshes dependency locks in validate_build for scheduled pipelines, matching the lock refresh performed by build before rebuilding JARs for comparison.

Also, when compareToReferenceJar fails, the reference and candidate JARs will be published as job job artifacts for inspection.

Motivation

Scheduled pipelines refresh dependency locks in build before producing the reference JARs. But validate_build did not had that step, so it rebuilt candidates from the committed lockfiles which can lead to a different dependency ordering.

This became visible after the version catalog requested dd-instrument-java:0.0.5 while the dd-trace-ot lockfile still declared 0.0.4.
Both build and validate_build jobs resolved to 0.0.5 (the jar content was correct), but the different lock file changed dependency input ordering.

dd-instrument-java is relocated, and its entries appeared at different positions in the dd-trace-ot Shadow JAR. While the content was identical, the jar itself had different hash on the different jobs.

To prevent that on scheduled pipelines validate_build now applies the same scheduled lock refresh as the build job. Allowing to build jars using the same dependency resolution order.

@@ relocated classes @@
- stale positions:     2680..2768
+ reference positions: 1681..1769
  89 entries under ddtrot/dd/instrument/{asm,classinject,classmatch,fieldinject,glue,utils}
@@ relocated directories @@
- stale positions:     3065..3072
+ reference positions: 2996..3003
  8 directory entries under ddtrot/dd/instrument/

Contributor Checklist

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@bric3 bric3 added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling comp: opentracing OpenTracing tag: ai generated Largely based on code generated by an AI or LLM labels Sep 3, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 3, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 59.02% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 43dc4a8 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 13.94 s [-0.4%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.96 s 13.01 s [-1.0%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.97 s 16.64 s [+0.9%; +3.0%] (maybe worse)
startup:petclinic:iast:Agent 16.83 s 17.00 s [-1.8%; -0.2%] (maybe better)
startup:petclinic:profiling:Agent 16.59 s 16.71 s [-1.6%; +0.2%] (no difference)
startup:petclinic:sca:Agent 16.95 s 16.09 s [+0.9%; +9.8%] (maybe worse)
startup:petclinic:tracing:Agent 15.60 s 16.19 s [-7.7%; +0.4%] (no difference)

Commit: f6a4a50b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3 bric3 changed the title Align dd-trace-ot dependency lock with dd-instrument-java Validate scheduled builds with refreshed dependency locks Sep 3, 2026
@bric3
bric3 marked this pull request as ready for review September 3, 2026 12:06
@bric3
bric3 requested review from a team as code owners September 3, 2026 12:06
@bric3
bric3 requested review from amarziali and erikayasuda and removed request for a team September 3, 2026 12:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T12:08:52.441476Z cd311bd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The scheduled validation now refreshes dependency locks in the same way as the reference build. The failure path puts both JAR sets in the existing job artifact directory.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit cd311bd · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but curious why we are not just excluding lock files from SHA?

@bric3

bric3 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@AlexeyKuznetsov-DD the lock files do not end up in the jar;) They however help gradle to resolve dependencies.

@bric3

bric3 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-03 19:19:31 UTC ℹ️ Start processing command /merge


2026-09-03 19:19:42 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-04 00:06:22 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-03 19:26:12 UTC ℹ️ Start processing command /code blockers


2026-09-03 19:26:12 UTC ℹ️ Devflow:

Checking merge blockers for #12392...


2026-09-03 19:26:15 UTC ℹ️ Devflow: /code blockers

Detected 2 merge blocker(s) to address:

🔴 Blocking

  • Required check Check system tests success has not reported
    Hint: Ensure the workflow that produces this check is triggered.

🟠 Pending

Comment thread .gitlab-ci.yml
Comment thread .gitlab-ci.yml
@bric3

bric3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 11:18:14 UTC ℹ️ Start processing command /merge


2026-09-04 11:18:24 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-04 12:56:28 UTC ⚠️ MergeQueue: This merge request was unqueued

brice.dutheil@datadoghq.com unqueued this merge request

@bric3

bric3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 12:55:08 UTC ℹ️ Start processing command /code blockers


2026-09-04 12:55:08 UTC ℹ️ Devflow:

Checking merge blockers for #12392...


2026-09-04 12:55:14 UTC ℹ️ Devflow: /code blockers

No merge blockers detected.

@bric3

bric3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 12:55:28 UTC ℹ️ Start processing command /merge


2026-09-04 12:55:31 UTC ❌ MergeQueue

PR already in the queue with status waiting

@bric3

bric3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge -c

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 12:56:22 UTC ℹ️ Start processing command /merge -c

@bric3

bric3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 12:59:12 UTC ℹ️ Start processing command /merge


2026-09-04 12:59:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-04 13:10:15 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 7ab3775:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@bric3

bric3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 13:15:07 UTC ℹ️ Start processing command /merge


2026-09-04 13:15:15 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-04 13:24:55 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 5bfd05b:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@bric3

bric3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 13:26:53 UTC ℹ️ Start processing command /merge


2026-09-04 13:26:59 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-04 15:12:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-04 16:23:00 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit f5776f9 into master Sep 4, 2026
600 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the fix/dd-trace-ot-shadow-order branch September 4, 2026 16:22
@github-actions github-actions Bot added this to the 1.66.0 milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: opentracing OpenTracing comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants