Skip to content

Preserve deterministic sampler rates - #12382

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
milan.garnier/preserve-deterministic-sampler-rate
Sep 3, 2026
Merged

Preserve deterministic sampler rates#12382
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
milan.garnier/preserve-deterministic-sampler-rate

Conversation

@MilanGarnier

@MilanGarnier MilanGarnier commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Preserves configured deterministic sampler rates at double precision.

Motivation

The sampler accepted a double but retained a float, so getSampleRate()
lost configured precision.

Additional Notes

Tested with ./gradlew :dd-trace-core:test --tests datadog.trace.common.sampling.DeterministicTraceSamplerTest --rerun-tasks.

Contributor Checklist

  • Applied comp: core, type: bug fix, and tag: ai generated labels.
  • No CODEOWNERS or public documentation updates are needed.

Jira ticket: N/A

@MilanGarnier MilanGarnier added type: bug fix Bug fix comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM labels Sep 2, 2026
@datadog-datadog-prod-us1-2

This comment has been minimized.

Sign in to view
@dd-octo-sts

dd-octo-sts Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.78 s 14.71 s [-0.3%; +1.4%] (no difference)
startup:insecure-bank:tracing:Agent 13.69 s 13.68 s [-0.7%; +0.8%] (no difference)
startup:petclinic:appsec:Agent 16.99 s 16.85 s [+0.2%; +1.4%] (maybe worse)
startup:petclinic:iast:Agent 16.91 s 16.91 s [-0.8%; +0.8%] (no difference)
startup:petclinic:profiling:Agent 16.69 s 16.66 s [-0.7%; +1.1%] (no difference)
startup:petclinic:sca:Agent 16.95 s 16.75 s [+0.1%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 15.58 s 16.02 s [-7.0%; +1.5%] (no difference)

Commit: 15636311 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@MilanGarnier
MilanGarnier marked this pull request as ready for review September 2, 2026 13:19
@MilanGarnier
MilanGarnier requested review from a team as code owners September 2, 2026 13:19
@MilanGarnier
MilanGarnier requested review from danyal002, leoromanovsky and mhlidd and removed request for a team September 2, 2026 13:19
datadog-datadog-prod-us1-2[bot]

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector[bot]

This comment was marked as resolved.

Sign in to view

@MilanGarnier
MilanGarnier removed the request for review from leoromanovsky September 2, 2026 13:27
@MilanGarnier
MilanGarnier force-pushed the milan.garnier/preserve-deterministic-sampler-rate branch from 4cd94ee to 58c6dc5 Compare September 2, 2026 13:29
@MilanGarnier
MilanGarnier removed the request for review from danyal002 September 2, 2026 13:31
mhlidd
mhlidd approved these changes Sep 2, 2026
View reviewed changes

@mhlidd mhlidd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM contingent on reverting ffe-system-test-data

Comment thread dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data
@mhlidd

mhlidd commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Merged w/ master to pull in CI fixes

@MilanGarnier
MilanGarnier force-pushed the milan.garnier/preserve-deterministic-sampler-rate branch from 8e80184 to d4ffb78 Compare September 3, 2026 12:29
@MilanGarnier
MilanGarnier added this pull request to the merge queue Sep 3, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-03 17:58:13 UTC ℹ️ Start processing command /merge

2026-09-03 17:58:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-03 18:45:48 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 3, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 023028c into master Sep 3, 2026
601 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the milan.garnier/preserve-deterministic-sampler-rate branch September 3, 2026 18:45
@github-actions github-actions Bot added this to the 1.66.0 milestone Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2[bot] datadog-datadog-prod-us1-2[bot] left review comments
@mhlidd mhlidd mhlidd approved these changes

Assignees

No one assigned

Labels

comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MilanGarnier @mhlidd