Make child-process tests portable across operating systems - #12355
Make child-process tests portable across operating systems#12355AlexeyKuznetsov-DD wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 256262607b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
The new echo helper changes valid values across operating systems. POSIX treats option-like values as flags, and Windows can write non-ASCII text in a charset that the migrated consumer does not use.
🤖 Datadog Autotest · Commit 2562626 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
dougqh
left a comment
There was a problem hiding this comment.
I see the bots have a few suggestions, but overall, this looks good to me.
Yep, I will process suggestions from bot before merge. |
What Does This Do
Adds
PortableCommandso tests can runecho,cat,sleep, and a non-terminating command without OS-specific call sites. POSIX keeps native utilities; Windows uses a small child JVM.Migrates
ProcessSupervisorTestandShellCommandExecutorTestto the portable commands.Motivation
Make child-process tests OS-independent without relying on Windows shell builtins or changing existing POSIX behavior.
Additional Notes
Validated the helper on the default JVM and Java 8, plus both migrated test classes: 43 focused test executions passed.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: N/A