Abstract OT-Baggage Tests - #12353
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 645abd3 | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
8ff2431 to
b11a96b
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b11a96b9f1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
The new abstract tests omit mixed-source limit coverage and two replacement-limit cases. A later baggage-limit regression can pass the reduced suite.
🤖 Datadog Autotest · Commit b11a96b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
… of mapped baggage and one header of traditional OT Baggage
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This PR removes the deduplication logic in OpenTracing Baggage unit tests by centralizing the test logic in
AbstractOTBaggageTest.java. Individual propagation style tests extend this abstract test class and feed propagation style specific extractors to validate extraction behavior for its propagation style.Motivation
#12303 introduced duplication of test class logic for OT Baggage.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]