Skip to content

Abstract OT-Baggage Tests - #12353

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
matthew.li/dedupe-baggage-limit-tests
Sep 1, 2026
Merged

Abstract OT-Baggage Tests#12353
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
matthew.li/dedupe-baggage-limit-tests

Conversation

@mhlidd

@mhlidd mhlidd commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

This PR removes the deduplication logic in OpenTracing Baggage unit tests by centralizing the test logic in AbstractOTBaggageTest.java. Individual propagation style tests extend this abstract test class and feed propagation style specific extractors to validate extraction behavior for its propagation style.

Motivation

#12303 introduced duplication of test class logic for OT Baggage.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Aug 31, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.95% (+19.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 645abd3 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.92 s 13.97 s [-1.1%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 12.96 s [-1.4%; +0.6%] (no difference)
startup:petclinic:appsec:Agent 16.72 s 16.72 s [-0.9%; +0.9%] (no difference)
startup:petclinic:iast:Agent 16.85 s 16.93 s [-1.2%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.68 s 16.31 s [-2.2%; +6.8%] (no difference)
startup:petclinic:sca:Agent 16.72 s 16.51 s [+0.3%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 15.51 s 16.09 s [-7.7%; +0.5%] (no difference)

Commit: 645abd3f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mhlidd mhlidd changed the title abstracting OT-Baggage tests Abstract OT-Baggage Tests Aug 31, 2026
@mhlidd
mhlidd force-pushed the matthew.li/dedupe-baggage-limit-tests branch from 8ff2431 to b11a96b Compare August 31, 2026 20:11
@mhlidd
mhlidd marked this pull request as ready for review August 31, 2026 20:50
@mhlidd
mhlidd requested a review from a team as a code owner August 31, 2026 20:50
@mhlidd
mhlidd requested review from mcculls and removed request for a team August 31, 2026 20:50
@dd-octo-sts

dd-octo-sts Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mhlidd mhlidd added tag: no release notes Changes to exclude from release notes type: refactoring comp: context propagation Trace context propagation comp: opentracing OpenTracing tag: ai generated Largely based on code generated by an AI or LLM labels Aug 31, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b11a96b9f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The new abstract tests omit mixed-source limit coverage and two replacement-limit cases. A later baggage-limit regression can pass the reduced suite.

Open Bits AI session

🤖 Datadog Autotest · Commit b11a96b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@mhlidd
mhlidd added this pull request to the merge queue Sep 1, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 1, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-01 15:20:16 UTC ℹ️ Start processing command /merge


2026-09-01 15:20:20 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-01 16:13:29 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 1, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit faa03ae into master Sep 1, 2026
601 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the matthew.li/dedupe-baggage-limit-tests branch September 1, 2026 16:13
@github-actions github-actions Bot added this to the 1.66.0 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: context propagation Trace context propagation comp: opentracing OpenTracing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants