Migrate dd-trace-core groovy files to java part 14 by jpbempel · Pull Request #12332 · DataDog/dd-trace-java

jpbempel · 2026-08-28T12:38:14Z

What Does This Do

we migrate 3 tests from traceAgentTest module

Motivation

this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
part4: #11146
part5: #11217
part6: #11362
part7: #11374
part8: #11437
part9: #11488
part10: #11543
part11: #11566
part12: #11619
part13: #12253

Additional Notes

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

dd-octo-sts · 2026-08-28T12:38:25Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41dae6b7d8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

datadog-datadog-prod-us1

After DDApiIntegrationTest runs locally, JUnit does not run the parent container cleanup. The Docker agent stays active.

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit 41dae6b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

dd-octo-sts · 2026-08-28T12:59:19Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.03 s	14.01 s	[-0.6%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent	12.91 s	13.03 s	[-1.7%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent	16.92 s	16.78 s	[-0.3%; +1.9%] (no difference)
startup:petclinic:iast:Agent	16.82 s	16.89 s	[-1.1%; +0.2%] (no difference)
startup:petclinic:profiling:Agent	16.43 s	16.31 s	[-5.0%; +6.4%] (unstable)
startup:petclinic:sca:Agent	16.18 s	16.57 s	[-6.7%; +2.0%] (no difference)
startup:petclinic:tracing:Agent	16.13 s	15.60 s	[-1.0%; +7.7%] (no difference)

Commit: 2e6ce66a · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

bric3

I spot a few things.

datadog-datadog-prod-us1

More details

The Java tests keep the same setup, input cases, checks, and helper behavior as the removed Groovy tests. The support changes only make report() available to tests and set the required format order.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit c9a1572 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

bric3

I'm not sure about the tabletest/google format change. But let's approve and we can revert that change specifically if there's an issue.

I'm OK with spotless off as well.

jpbempel · 2026-09-02T04:34:05Z

/code blockers

gh-worker-devflow-routing-ef8351 · 2026-09-02T17:30:24Z

View all feedbacks in Devflow UI.

2026-09-02 17:30:24 UTC ℹ️ Start processing command /merge -c

dd-octo-sts · 2026-09-02T20:21:20Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-02T20:21:24Z

View all feedbacks in Devflow UI.

2026-09-02 20:21:24 UTC ℹ️ Start processing command /merge

2026-09-02 20:21:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-02 20:36:42 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 0916ea3:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

dd-octo-sts · 2026-09-03T19:24:20Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-03T19:24:24Z

View all feedbacks in Devflow UI.

2026-09-03 19:24:24 UTC ℹ️ Start processing command /merge

2026-09-03 19:24:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-03 19:32:10 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for f905b1f:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

we migrate 3 tests from traceAgentTest module

dd-octo-sts · 2026-09-04T05:37:00Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-04T05:37:04Z

View all feedbacks in Devflow UI.

2026-09-04 05:37:03 UTC ℹ️ Start processing command /merge

2026-09-04 05:37:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-04 06:50:10 UTC ℹ️ MergeQueue: This merge request was merged

…nerator master migrated dd-trace-core/src/traceAgentTest/groovy/TraceGenerator.groovy to Java (#12332) after this branch changed the same file's Metadata constructor call. Take master's migrated TraceGenerator.java and port the httpStatusCode null -> 0 change onto it, matching the same edit already applied to the sibling test/java/.../writer/TraceGenerator.java and DDSpanContext.java in this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

jpbempel requested review from a team as code owners August 28, 2026 12:38

jpbempel requested review from AlexeyKuznetsov-DD and mcculls and removed request for a team August 28, 2026 12:38

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread dd-trace-core/src/traceAgentTest/java/DDApiIntegrationTest.java Outdated

Comment thread dd-trace-core/src/traceAgentTest/java/DataStreamsIntegrationTest.java Outdated

datadog-datadog-prod-us1 Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread dd-trace-core/src/traceAgentTest/java/DDApiIntegrationTest.java Outdated

This comment has been minimized.

Sign in to view

jpbempel added comp: testing Testing type: refactoring tag: no release notes Changes to exclude from release notes labels Aug 28, 2026

dougqh approved these changes Aug 28, 2026

View reviewed changes

mcculls approved these changes Aug 30, 2026

View reviewed changes

jpbempel enabled auto-merge August 31, 2026 08:42

bric3 reviewed Aug 31, 2026

View reviewed changes

jpbempel force-pushed the jpbempel/g2j-core-pt14 branch from 9837eba to 50b2e96 Compare September 1, 2026 13:36

jpbempel requested a review from a team as a code owner September 1, 2026 15:14

datadog-datadog-prod-us1 Bot reviewed Sep 1, 2026

View reviewed changes

AlexeyKuznetsov-DD approved these changes Sep 1, 2026

View reviewed changes

robcarlan-datadog approved these changes Sep 1, 2026

View reviewed changes

bric3 approved these changes Sep 1, 2026

View reviewed changes

gh-worker-ownership-write-b05516 Bot removed the request for review from a team September 1, 2026 18:07

jpbempel disabled auto-merge September 2, 2026 04:33

jpbempel enabled auto-merge September 2, 2026 04:33

jpbempel added this pull request to the merge queue Sep 2, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 2, 2026

jpbempel force-pushed the jpbempel/g2j-core-pt14 branch 2 times, most recently from 0f793f8 to 57151a7 Compare September 3, 2026 15:45

jpbempel added this pull request to the merge queue Sep 3, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 3, 2026

jpbempel added 9 commits September 4, 2026 06:44

Migrate dd-trace-core groovy files to java part 14

6b6d287

we migrate 3 tests from traceAgentTest module

address codex comments

cd9406b

spotless

94a118e

address comments

2a02fe2

fix spotless

a4c4aab

fix scenario names

5775bdc

spotless

3a60257

spotless

8a2155d

spotless

2e6ce66

jpbempel force-pushed the jpbempel/g2j-core-pt14 branch from 57151a7 to 2e6ce66 Compare September 4, 2026 04:46

jpbempel enabled auto-merge September 4, 2026 05:28

jpbempel added this pull request to the merge queue Sep 4, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 4, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 2f3ce44 into master Sep 4, 2026
601 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/g2j-core-pt14 branch September 4, 2026 06:50

github-actions Bot added this to the 1.66.0 milestone Sep 4, 2026

Uh oh!

Conversation

jpbempel commented Aug 28, 2026

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

dd-octo-sts Bot commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpbempel commented Sep 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Sep 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

dd-octo-sts Bot commented Sep 3, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

dd-octo-sts Bot commented Sep 4, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dd-octo-sts Bot commented Aug 28, 2026 •

edited

Loading

bric3 left a comment •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 2, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 2, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026 •

edited

Loading