Fix sfn x-datadog-tags input - #12320
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3bb82d7 to
0620e0c
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: 5448550 | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The configured propagator writes the required sampling priority and string-valued propagation tags without a reportable regression.
🤖 Datadog Autotest · Commit e7f5aca · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
Approving, but I would ask for review @DylanLovesCoffee (as I can see from commits history)
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
uses standard context propagator to build stepfunctions input rather than manually written json
x-datadog-tagsinput no longer encodes span tags but rather the expected_dd.p.*string. The previous value was getting dropped by the extension. This mirrors the values in the other aws integrations ( sns, eventbridge, etc)Motivation
SLES-2981
x-datadog-tagsis defined as a string, but it was being emitted as an object. This caused the extension's Step Functions deserializer to reject the whole_datadogpayload.Additional Notes
non
datadog-x-*style payload inputs can be injected but do not get extracted on the extension side. That is a limitation right now, but is consistent with other implementations in this and other tracers. Any fix would be on the extension sideConsistent with the SNS and EventBridge instrumentations in this repo, and with how dd-trace-js and dd-trace-py build the same
_datadogpayload.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: SLES-2981