Use the unified Hashtable API in client-side stats (perf toolbox) - #12312

Draft

dougqh wants to merge 65 commits into

feat/hashtable-api-unificationfrom

feat/client-side-stats-hashtable-api

Commits on Aug 25, 2026

Add EmbeddingSupport.contains(hashes, names, name) helper

dougqh
and
claude
committed
2e312fa
Add hitFresh scenario and hash-dispatch pollution to ImmutableSetBenchmark

dougqh
and
claude
committed
760ad2c

Commits on Aug 26, 2026

Restructure StringIndex put/indexOf around a single induction variable
dougqh
committed
7de549a
Split BenchmarkUtils type-profile pollution into add-driving and contains-only helpers
dougqh
committed
f675151
Scope StringIndex-as-Set guidance to hit-dominated access patterns
dougqh
committed
9f40da9
Pollute type dispatch in ImmutableMapBenchmark and refresh results
dougqh
committed
b55310a
Extend BenchmarkUtils with ConcurrentHashMap and Map-dispatch pollution
dougqh
committed
ea15440
Wire BenchmarkUtils.polluteHashDispatch into the remaining map/set benchmarks
dougqh
committed
f54f1dc
Record pollution-corrected results in SingleThreadedMapBenchmark
dougqh
committed
1c83f2b
Record pollution-corrected results in SingleThreadedSetBenchmark
dougqh
committed
dcfc9e7
Record pollution-corrected results in ThreadSafeMapBenchmark
dougqh
committed
aa889af
Record pollution rerun results in HashtableD1Benchmark
dougqh
committed
e34f87c
Record pollution rerun results in HashtableD2Benchmark
dougqh
committed
d3c3595
Record pollution rerun results in CaseInsensitiveMapBenchmark
dougqh
committed
b0c6cf4
Record pollution rerun results in TagMapAccessBenchmark
dougqh
committed
d61d4ae
Correct HashtableD1Benchmark's pollution-immunity rationale
dougqh
committed
82d1adb
Correct HashtableD2Benchmark's pollution-immunity rationale
dougqh
committed
3d6d044
Attribute CaseInsensitiveMapBenchmark's rerun slowdown to JDK 8 on ARM64
dougqh
committed
2298224
Attribute TagMapAccessBenchmark's rerun slowdown to JDK 8 on ARM64
dougqh
committed
226dd76
Record Java 17 rerun for HashtableD1Benchmark
dougqh
committed
dbed8a1
Record Java 17 rerun for HashtableD2Benchmark
dougqh
committed
8bbe287
Unify Hashtable static API with ConcurrentHashtable; deprecate Support

dougqh
and
claude
committed
f932ad8
Migrate HashtableTest to blessed Hashtable static API

dougqh
and
claude
committed
5367290
Hashtable: annotate nullability (@Nonnull/@Nullable)

dougqh
and
claude
committed
f0a72ab
Rename Hashtable.insertHeadEntry overloads to insertHeadEntryAt/For

dougqh
and
claude
committed
5a7d245
Add a strict entry-count cap to Hashtable.D1/D2
dougqh
committed
54a0760
Handle Hashtable.D1's new strict cap in CardinalityLimitReporter
dougqh
committed
c4c230d
Add Hashtable.SizeTracker, EvictionCursor, and Table building blocks

dougqh
and
claude
committed
0d2491d
Back Hashtable.D1/D2's entry-count cap with SizeTracker

dougqh
and
claude
committed
c04c3de
Port drain from ConcurrentHashtable to Hashtable

dougqh
and
claude
committed
96dd249
Expose isFull on D1/D2

dougqh
and
claude
committed
e64b384
Mark Hashtable D1/D2 getOrCreate as @Nullable

dougqh
and
claude
committed
5543d30
Unify the Hashtable factory API on a capped/uncapped vocabulary

dougqh
and
claude
committed
b3e59f3
Avoid a capturing predicate in Hashtable D1/D2 remove

dougqh
and
claude
committed
c2b9acf
Lead the size-tracked Hashtable statics with the SizeTracker

dougqh
and
claude
committed
3f4c479
Drop references to the deprecated Support facade from Hashtable javadoc

dougqh
and
claude
committed
c630240
Lead getOrCreate's javadoc with the fact that it can refuse

dougqh
and
claude
committed
69ae56f
Rename getOrCreate to tryGetOrCreate on Hashtable and FlatHashtable

dougqh
and
claude
committed
8829af1
Replace Hashtable insertOrReplace with a refusing tryInsertOrReplace

dougqh
and
claude
committed
5a9c328
Clean up Hashtable comments: drop outward references, order by use

dougqh
and
claude
committed
09c356f
Fold SizeTracker and EvictionCursor into one SizeManager

dougqh
and
claude
committed
5851b46
Rename Hashtable.Table to State and make it something you hold

dougqh
and
claude
committed
1c370d9
Take State in the size-tracked statics; keep eviction static too

dougqh
and
claude
committed
c893117
Round out the State-taking statics: size, isEmpty, bucketFor, forEach

dougqh
and
claude
committed
050c304
Add size-tracked drain; fix two review nits

dougqh
and
claude
committed
33e9f4f

Commits on Aug 27, 2026

Step the eviction cursor on a failed scan; name the count honestly

dougqh
and
claude
committed
4c4509d
Fix two eviction/drain defects found by Codex review

dougqh
and
claude
committed
3909184
Add a selection guide to Hashtable and FlatHashtable

dougqh
and
claude
committed
2d6bdb9
Add Hashtable.D1/D2 tryGetOrUpdate to keep the cap refusal off the caller's path

dougqh
and
claude
committed
2dab029
Add a primitive-long context overload of Hashtable.D1.tryGetOrUpdate

dougqh
and
claude
committed
60b3b11
Record the capped-table rerun of HashtableD1Benchmark

dougqh
and
claude
committed
d813ca0

Commits on Aug 28, 2026

Assert against double-inserting the same Entry instance
dougqh
committed
b756710
Carry Maybe<T> forward pending #12328 merge
dougqh
committed
a0629a1
Add Maybe-returning tryGetOrCreateAsMaybe to Hashtable and FlatHashtable
dougqh
committed
effe9ea
Promote tryGetOrCreateAsMaybe to tryGetOrCreate, demote nullable form to tryGetOrCreateOrNull
dougqh
committed
ccf2f1b
Migrate AggregateTable to the blessed Hashtable API

dougqh
and
claude
committed
1d9c2c0
Encapsulate the staleness rule as AggregateEntry.isStale

dougqh
and
claude
committed
ee128fb
Reach State only through the statics in AggregateTable

dougqh
and
claude
committed
6461012
Follow the estimateSize/isLikelyEmpty rename in AggregateTable

dougqh
and
claude
committed
e565370
Rehome the eviction rationale after deleting evictOneStale

dougqh
and
claude
committed
8ad2642
Delete the deprecated Hashtable.Support facade

dougqh
and
claude
committed
b4af2d9
Fuse the CardinalityLimitReporter counter bump into tryGetOrUpdate

dougqh
and
claude
committed
fa402d6
Rewrap an AggregateTable javadoc paragraph per spotless

dougqh
and
claude
committed
7a61535
Fuse CardinalityLimitReporter.record via Maybe, inline the count-bump as a method reference
dougqh
committed
4d41f3f
Inline AggregateEntry::isStale at its call sites, drop the STALE field
dougqh
committed
ab7ec53