Skip to content

Enable Pekko HTTP forked tests - #12310

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
alexeyk/enable-pekko-forked-tests
Sep 8, 2026
Merged

Enable Pekko HTTP forked tests#12310
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
alexeyk/enable-pekko-forked-tests

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Enables the six existing Pekko HTTP *ForkedTest classes across the base, latest Pekko 1.0.x, and latest dependency test suites.

It also fixes the failures exposed by that coverage:

  • skips context injection when singleRequest receives a null request;
  • verifies the null-carrier path directly; and
  • updates the exception-span assertions for schema-specific operation names and absent peer metadata.

Motivation

Pekko's tests live in custom source sets, so the default forkedTest task used the empty test source set. The six forked classes were compiled but never executed.

Enabling them exposed a suppressed Data Streams injection failure when the existing exception test calls singleRequest(null):

java.lang.NullPointerException: Cannot invoke "HttpRequest.addHeader(...)" because "this.request" is null
    at PekkoHttpClientHelpers$PekkoHttpHeaders.set(...)
    at DataStreamsPropagator.injectPathwayContext(...)

The context-propagation advice now returns before injection when there is no carrier. Normal requests are unchanged.

Additional Notes

This PR is stacked on #12308, which is stacked on #12147.

Validation:

./gradlew :dd-java-agent:instrumentation:pekko:pekko-http-1.0:baseTestForkedTest :dd-java-agent:instrumentation:pekko:pekko-http-1.0:latestPekko10TestForkedTest :dd-java-agent:instrumentation:pekko:pekko-http-1.0:latestDepTestForkedTest --rerun-tasks
./gradlew :dd-java-agent:instrumentation:pekko:pekko-http-1.0:spotlessCheck

The forked-test matrix ran 894 cases across 18 isolated class executions: 0 failures, 0 errors, and 402 conditionally skipped cases.

muzzle could not complete locally because Maven Central range metadata resolution returned no versions for the existing pekko-http_2.12:[1.0.0,) range after retries. This PR does not change the muzzle configuration.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: ai generated Largely based on code generated by an AI or LLM comp: testing Testing type: bug fix Bug fix tag: no release notes Changes to exclude from release notes labels Aug 26, 2026
@datadog-datadog-prod-us1-2

This comment has been minimized.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Aug 26, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 13.92 s [-0.2%; +1.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 12.95 s [-0.6%; +0.8%] (no difference)
startup:petclinic:appsec:Agent 17.04 s 17.35 s [-6.1%; +2.5%] (no difference)
startup:petclinic:iast:Agent 17.34 s 17.41 s [-1.3%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.90 s 17.22 s [-6.4%; +2.7%] (no difference)
startup:petclinic:sca:Agent 17.47 s 16.95 s [-1.4%; +7.5%] (no difference)
startup:petclinic:tracing:Agent 16.46 s 16.63 s [-2.3%; +0.1%] (no difference)

Commit: 9f6fb65b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added the tag: override groovy enforcement Override the "Enforce Groovy Migration" check label Aug 26, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD force-pushed the alexeyk/enable-pekko-forked-tests branch from 31827e8 to 6edf27b Compare September 4, 2026 00:06

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Nice find !

Base automatically changed from alexeyk/reuse-forked-test-tasks to master September 4, 2026 22:51
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD force-pushed the alexeyk/enable-pekko-forked-tests branch from 6edf27b to e563c17 Compare September 4, 2026 23:04
leoromanovsky and others added 3 commits September 8, 2026 09:56
Add proxy-aware feature flag intake authentication

Route direct feature flag intake through standard HTTPS proxy settings and attach the canonical fixed-width API key fingerprint.

Environment: Datadog workspace

Separate direct intake proxying from API key fingerprinting

Keep this PR focused on proxy-aware direct Event Platform intake and leave fingerprinting to an independent change.

Environment: Datadog workspace

Merge live Java master after EVP split

Restore Java formatting after the fingerprint split

Keep the direct-intake diff free of fingerprint-only formatting artifacts.

Environment: Datadog workspace

Update direct-intake tests after fingerprint removal

Use the original two-argument direct intake factory now that the unrelated fingerprint header plumbing has moved out of this PR.

Environment: Datadog workspace

Remove unnecessary Groovy imports

fix(feature-flags): handle ambiguous EVP failures safely

fix(feature-flags): validate direct EVP intake site

Reject URL authority confusion before adding DD-API-KEY.

Environment: Datadog workspace

fix(config): align proxy configuration validation

Read standard proxy environment variables without registering them as Datadog configuration aliases, and use the existing non-regex parser for no-proxy hosts.

Environment: Datadog workspace

fix(feature-flags): reject direct intake redirects

Disable HTTP and HTTPS redirects for Feature Flags direct EVP intake so DD-API-KEY remains bound to the configured origin.

Environment: Datadog workspace

fix(feature-flags): harden proxy configuration

Preserve one-character NO_PROXY entries and prevent HTTPS proxy URLs from exposing credentials through configuration telemetry.

Environment: Datadog workspace

Merge remote-tracking branch 'origin/master' into leo.romanovsky/ffe-agentless-evp-java-hardening

# Conflicts:
#	utils/config-utils/src/main/java/datadog/trace/api/ConfigSetting.java
#	utils/config-utils/src/test/java/datadog/trace/api/ConfigSettingTest.java

refactor(feature-flags): narrow direct intake hardening

Keep direct intake origin and redirect protections while removing proxy and runtime failover changes.

Environment: Datadog workspace

Merge branch 'master' into leo.romanovsky/ffe-agentless-evp-java-hardening\n\nEnvironment: Datadog workspace

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD force-pushed the alexeyk/enable-pekko-forked-tests branch from 53cace0 to 8adad42 Compare September 8, 2026 13:56
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review September 8, 2026 13:57
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners September 8, 2026 13:57
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from sarahchen6 and ygree and removed request for a team September 8, 2026 13:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T14:01:35.479585Z 8adad42 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The forked tasks use each custom Pekko test source set. The null request guard stops context injection and does not change normal requests.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 8adad42 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@ygree ygree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I wonder if there are other cases like this one where tests were mistakenly excluded from the bulk run.

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the build.gradle changes

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 8, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-08 19:35:58 UTC ℹ️ Start processing command /merge


2026-09-08 19:36:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-08 20:31:59 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit c3dca9c into master Sep 8, 2026
600 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/enable-pekko-forked-tests branch September 8, 2026 20:31
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes tag: override groovy enforcement Override the "Enforce Groovy Migration" check type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants