Skip to content

Add support for native_socket ddprof config - #12175

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
paul.fournillon/native_socket_flag
Aug 18, 2026
Merged

Add support for native_socket ddprof config#12175
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
paul.fournillon/native_socket_flag

Conversation

@kaahos

@kaahos kaahos commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Wire ddprof natsock flag.

Motivation

Add support for optional parameter to enable Native Socket I/O events emission.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@kaahos kaahos added type: feature Enhancements and improvements comp: profiling Profiling labels Aug 10, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 58.38% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fb08a66 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.83 s 14.70 s [+0.1%; +1.8%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.53 s 13.63 s [-1.5%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 17.46 s 17.25 s [+0.0%; +2.4%] (maybe worse)
startup:petclinic:iast:Agent 17.43 s 16.98 s [-1.8%; +7.1%] (no difference)
startup:petclinic:profiling:Agent 17.48 s 17.35 s [-0.3%; +1.8%] (no difference)
startup:petclinic:sca:Agent 17.53 s 17.29 s [+0.3%; +2.5%] (maybe worse)
startup:petclinic:tracing:Agent 16.64 s 16.55 s [-0.5%; +1.6%] (no difference)

Commit: fb08a668 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@kaahos
kaahos force-pushed the paul.fournillon/native_socket_flag branch from 8f11a98 to 55c1a16 Compare August 11, 2026 15:35
@kaahos
kaahos force-pushed the paul.fournillon/native_socket_flag branch from 55c1a16 to b6cf231 Compare August 13, 2026 22:07
@kaahos
kaahos marked this pull request as ready for review August 17, 2026 08:48
@kaahos
kaahos requested review from a team as code owners August 17, 2026 08:48
@kaahos
kaahos requested review from amarziali and jbachorik and removed request for a team August 17, 2026 08:48

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The opt-in configuration maps cleanly to ddprof’s natsock[=<interval>] contract: disabled or absent values leave existing commands unchanged, while enabled values select the new mode. The bundled ddprof release line contains the corresponding parser and bare-option default behavior.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 3f08722 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@kaahos
kaahos requested a review from jbachorik August 18, 2026 12:27

@jbachorik jbachorik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kaahos
kaahos enabled auto-merge August 18, 2026 12:53
@kaahos
kaahos added this pull request to the merge queue Aug 18, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 18, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-18 13:46:11 UTC ℹ️ Start processing command /merge


2026-08-18 13:46:16 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-18 15:03:45 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 18, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit bc42364 into master Aug 18, 2026
601 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the paul.fournillon/native_socket_flag branch August 18, 2026 15:03
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 18, 2026
@daniel-mohedano daniel-mohedano changed the title feat: add support for native_socket ddprof config Add support for native_socket ddprof config Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: profiling Profiling type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants